This repository has been archived by the owner on Aug 31, 2021. It is now read-only.
Libevent2 #35
Open
Libevent2 #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
short summary is this: libevent2 transition is pretty straight forward. A few methods are depreciated, and we could continue using them, but we should switch to new methods that take an explicit event_base (exposed now as simplehttp_event_base). Other stuff that are old structures which aren't ideal to use have *_compat.h includes or *_struct.h includes that just need to be added; using those makes things brittle as it introduces binary incompatibility, but there isn't any other downside to using them. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress, but this is to cover some exploratory changes to switch to libevent2. The end of this may or may not result in immediate merging of this, but it will help define the scope of changes necessary to link against libevent2.