Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/Ghost] Correctly handle smtpExistingSecret value #31179

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

AverageMarcus
Copy link

Description of the change

Correctly handles setting either .Values.smtpPassword or .Values.smtpExistingSecret. Default smtp-password is now created in its own Secret if an existing is not provided.

Benefits

Fixes the need to provide a dummy smtpPassword value when using an external secret.

Possible drawbacks

The SMTP secret, if an existing Secret resource is not provided, is now in its own Secret resource rather than the one used for the Ghost auth credentials (to be more in-line with the database secret)

Applicable issues

Additional information

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

@github-actions github-actions bot added ghost triage Triage is needed labels Dec 28, 2024
@github-actions github-actions bot requested a review from javsalgar December 28, 2024 15:45
Signed-off-by: Bitnami Containers <[email protected]>
@carrodher carrodher added verify Execute verification workflow for these changes in-progress labels Dec 28, 2024
@github-actions github-actions bot removed the triage Triage is needed label Dec 28, 2024
@github-actions github-actions bot removed the request for review from javsalgar December 28, 2024 23:52
@github-actions github-actions bot requested a review from alvneiayu December 28, 2024 23:52
Signed-off-by: Bitnami Containers <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]>
Copy link
Contributor

@alvneiayu alvneiayu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for sending a PR. I included some comments.

@@ -204,13 +204,11 @@ spec:
- name: GHOST_SMTP_USER
value: {{ .Values.smtpUser | quote }}
{{- end }}
{{- if .Values.smtpPassword }}
Copy link
Contributor

@alvneiayu alvneiayu Jan 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, the pipelines are failing because you need to keep this. If not you are deploying a deployment trying to get a secret without the key smtp-password because is empty

---
{{- end }}

{{- if not .Values.smtpExistingSecret }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to check here the smtpPassword, you are creating an empty secret without data in this case.

Copy link

This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution.

@github-actions github-actions bot added the stale 15 days without activity label Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ghost in-progress stale 15 days without activity verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bitnami/ghost] smtpExistingSecret value is ignored
5 participants