-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bitnami/Ghost] Correctly handle smtpExistingSecret value #31179
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Marcus Noble <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]>
Signed-off-by: Bitnami Containers <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for sending a PR. I included some comments.
@@ -204,13 +204,11 @@ spec: | |||
- name: GHOST_SMTP_USER | |||
value: {{ .Values.smtpUser | quote }} | |||
{{- end }} | |||
{{- if .Values.smtpPassword }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, the pipelines are failing because you need to keep this. If not you are deploying a deployment trying to get a secret without the key smtp-password because is empty
--- | ||
{{- end }} | ||
|
||
{{- if not .Values.smtpExistingSecret }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you need to check here the smtpPassword, you are creating an empty secret without data in this case.
This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution. |
Description of the change
Correctly handles setting either
.Values.smtpPassword
or.Values.smtpExistingSecret
. Default smtp-password is now created in its own Secret if an existing is not provided.Benefits
Fixes the need to provide a dummy
smtpPassword
value when using an external secret.Possible drawbacks
The SMTP secret, if an existing Secret resource is not provided, is now in its own Secret resource rather than the one used for the Ghost auth credentials (to be more in-line with the database secret)
Applicable issues
smtpExistingSecret
value is ignored #8916Additional information
Checklist
Chart.yaml
according to semver. This is not necessary when the changes only affect README.md files.README.md
using readme-generator-for-helm