Pylint alerts corrections as part of intervention experiment #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed unneeded parenthesis in if
Removed unneeded parenthesis in if
The main function had 13 branches while it is recommended to have at most 12. I extracted one function, _set_output_directory. This is a minimal change fixing the alert/
enumerate_domains had 15 branches while 12 are recommended. I removed the handling of UnicodeError and subprocess.TimeoutExpired which just pass, as the else. I also extracted _handle_nmap
Made 2 readable lines shorter
Made a readable line shorter
Removed two unnecessary pass commands. They look like leftovers.
Made a readable line shorter
If had 6 terms, it is recommended not to have more than 5. I extracted the logic of checking two variable, making the logic more structured.
print_banner comment says that it should print the credits but it implementation is just pass. I removed the function and the single call to it, giving the same credit in less code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the interventions describe in intervention issue.
The experiment is described here.
Each intervention was done in a dedicated commit with a message explaining it.