deserialization of comptime structs #22
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gballet
commented
Jan 2, 2025
| if (try isFixedSizeObject(T)) { | ||
| var i: usize = 0; | ||
| const pitch = @sizeOf(T); | ||
| while (i < out.len) : (i += pitch) { |
There was a problem hiding this comment.
that used to be inline in the calling code. That made no sense and yet it worked.
gballet
commented
Jan 2, 2025
Comment on lines
+154
to
+159
| .name = try std.testing.allocator.alloc(u8, 5), | ||
| .age = 32, | ||
| .company = try std.testing.allocator.alloc(u8, 8), | ||
| }; | ||
| @memcpy(data.name, "James"); | ||
| @memcpy(data.company, "DEV Inc."); |
There was a problem hiding this comment.
this can be fixed using @as(, @constCast
gballet
commented
Jan 2, 2025
| @@ -347,17 +366,17 @@ test "deserializes a string" { | |||
| } | |||
|
|
|||
| const Pastry = struct { | |||
| name: []const u8, | |||
| name: []u8, | |||
There was a problem hiding this comment.
deserialization only worked because it was returning a direct pointer to the serialized payload, which is []const u8 itself.
gballet
commented
Jan 2, 2025
| // Taken from ssz.cr | ||
| const Person = struct { | ||
| name: []const u8, | ||
| name: []u8, | ||
| age: u8, |
There was a problem hiding this comment.
interestingly, this also causes the same "comptime ref" issue, and so I need a more complete workaround for it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is probably a dead-end since I am trying to force the deserialization of a structure that is inherently
comptime. Still, I want to keep experimenting in order to see how far I can push this boundary.The issues with this approach are that: