Unify stats across relevant pages #2561
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tom2drum
reviewed
Feb 11, 2025
| return 'N/A'; | ||
| })(); | ||
|
|
||
| // we have diffs only for coin adn second coin price charts that get data from stats api |
There was a problem hiding this comment.
Suggested change
| // we have diffs only for coin adn second coin price charts that get data from stats api | |
| // we have diffs only for coin and second coin price charts that get data from stats api |
| return null; | ||
| } | ||
|
|
||
| const isLoading = isStatsFeatureEnabled ? countersStatsQuery.isPlaceholderData : countersApiQuery.isPlaceholderData; | ||
|
|
||
| const contractsCount = isStatsFeatureEnabled ? countersStatsQuery.data?.total_contracts?.value : countersApiQuery.data?.smart_contracts; |
There was a problem hiding this comment.
Shouldn't we always fall back to our regular API response, regardless of whether microservices data is enabled? For example, if there is an error in the response from the stats microservices, should we still display the information from our base API?
Comment on lines
+15
to
27
| const txsStatsQuery = useApiQuery('stats_transactions', { | ||
| queryOptions: { | ||
| enabled: isStatsFeatureEnabled, | ||
| placeholderData: isStatsFeatureEnabled ? TXS_STATS_MICROSERVICE : undefined, | ||
| }, | ||
| }); | ||
|
|
||
| const txsStatsApiQuery = useApiQuery('txs_stats', { | ||
| queryOptions: { | ||
| placeholderData: TXS_STATS, | ||
| enabled: !isStatsFeatureEnabled, | ||
| placeholderData: !isStatsFeatureEnabled ? TXS_STATS : undefined, | ||
| }, | ||
| }); |
There was a problem hiding this comment.
The same comment about fallback applies here.
I suggest abstracting these two hooks into a separate one that will orchestrate all requests and return the isLoading flag and data in a common format. This way, all necessary logic will be encapsulated in one place rather than be spreaded in the view component.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and Related Issue(s)
resolves #2515
Proposed Changes
added daily_operational_txs option to NEXT_PUBLIC_HOMEPAGE_CHARTS and total_operational_txs to NEXT_PUBLIC_HOMEPAGE_STATS. Values can be used only if NEXT_PUBLIC_STATS_API_HOST is provided
Checklist for PR author