suppress -Warray-bounds in bdlc_indexclerk (DRQS 176376910) (#4907)

* suppress -Warray-bounds in bdlc_indexclerk

* add missing include

groups/bdl/bdlc/bdlc_indexclerk.cpp

@@ -12,6 +12,17 @@ BSLS_IDENT_RCSID(bdlc_indexclerk_cpp,"$Id$ $CSID$")
 #include <bsl_ostream.h>
 #include <bsl_vector.h>
 
+///Implementation Notes
+///--------------------
+// When 'BSLS_ASSERT' is enabled and 'IndexClerkIter::operator*' is inlined,
+// GCC 12 to 14 (the latest version at the time of writing) can sometimes
+// optimize the code into a form that duplicates the access to 'd_index_p' in
+// the branch where '0 == d_index_p.base()', which triggers '-Warray-bounds'
+// (GCC bug 108770).  The ideal solution is to replace 'BSLS_ASSERT' with a
+// variant that is statically known to never continue on failure, but such a
+// facility doesn't currently exist in BDE, so instead we must manually disable
+// the warning in the body of 'operator*'.
+
 namespace BloombergLP {
 namespace bdlc {
 

groups/bdl/bdlc/bdlc_indexclerk.h

@@ -128,6 +128,7 @@ BSLS_IDENT("$Id: $")
 #include <bslmf_nestedtraitdeclaration.h>
 
 #include <bsls_assert.h>
+#include <bsls_platform.h>
 #include <bsls_review.h>
 
 #include <bsl_iosfwd.h>
@@ -456,9 +457,19 @@ IndexClerkIter& IndexClerkIter::operator--()
 inline
 int IndexClerkIter::operator*() const
 {
+#if defined(BSLS_PLATFORM_CMP_GNU) && \
+    BSLS_PLATFORM_CMP_VERSION >= 120000 && BSLS_PLATFORM_CMP_VERSION < 150000
+    // See implementation notes in the .cpp file for explanation.
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Warray-bounds"
+#endif
     BSLS_ASSERT(0 != d_index_p.base());
 
     return *d_index_p;
+#if defined(BSLS_PLATFORM_CMP_GNU) && \
+    BSLS_PLATFORM_CMP_VERSION >= 120000 && BSLS_PLATFORM_CMP_VERSION < 150000
+#pragma GCC diagnostic pop
+#endif
 }
 
 }  // close package namespace