Skip to content

Commit

Permalink
reduce td warnings (#4822)
Browse files Browse the repository at this point in the history 
* reduce td warnings

* remove bad whitespace
  • Loading branch information
Jeffrey Mendelsohn authored and GitHub Enterprise committed Jul 11, 2024
1 parent 6d6e099 commit 9b27510
Show file tree
Hide file tree
Showing 56 changed files with 300 additions and 137 deletions.
4 changes: 2 additions & 2 deletions groups/bdl/bdlat/bdlat_arrayfunctions.t.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,7 @@ int GetValue<LVALUE_TYPE>::operator()(const LVALUE_TYPE& object) const

template <class LVALUE_TYPE>
template <class RVALUE_TYPE>
int GetValue<LVALUE_TYPE>::operator()(const RVALUE_TYPE& object) const
int GetValue<LVALUE_TYPE>::operator()(const RVALUE_TYPE& /* object */) const
{
return -1;
}
Expand Down Expand Up @@ -276,7 +276,7 @@ int AssignValue<RVALUE_TYPE>::operator()(RVALUE_TYPE *object) const

template <class RVALUE_TYPE>
template <class LVALUE_TYPE>
int AssignValue<RVALUE_TYPE>::operator()(LVALUE_TYPE *object) const
int AssignValue<RVALUE_TYPE>::operator()(LVALUE_TYPE * /* object */) const
{
return -1;
}
Expand Down
4 changes: 2 additions & 2 deletions groups/bdl/bdlat/bdlat_nullablevaluefunctions.t.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ int GetValue<LVALUE_TYPE>::operator()(const LVALUE_TYPE& object) const

template <class LVALUE_TYPE>
template <class RVALUE_TYPE>
int GetValue<LVALUE_TYPE>::operator()(const RVALUE_TYPE& object) const
int GetValue<LVALUE_TYPE>::operator()(const RVALUE_TYPE& /* object */) const
{
return -1;
}
Expand Down Expand Up @@ -186,7 +186,7 @@ int AssignValue<RVALUE_TYPE>::operator()(RVALUE_TYPE *object) const

template <class RVALUE_TYPE>
template <class LVALUE_TYPE>
int AssignValue<RVALUE_TYPE>::operator()(LVALUE_TYPE *object) const
int AssignValue<RVALUE_TYPE>::operator()(LVALUE_TYPE * /* object */) const
{
return -1;
}
Expand Down
18 changes: 9 additions & 9 deletions groups/bdl/bdlat/bdlat_typecategory.t.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1104,7 +1104,7 @@ int main(int argc, char *argv[])
{
typedef int Type;

Type object;
Type object = 0;
MyAccessor accessor;

ASSERT(bdlat_TypeCategory::e_SIMPLE_CATEGORY
Expand All @@ -1115,7 +1115,7 @@ int main(int argc, char *argv[])
{
typedef char Type;

Type object;
Type object = ' ';
MyAccessor accessor;

ASSERT(bdlat_TypeCategory::e_SIMPLE_CATEGORY
Expand All @@ -1126,7 +1126,7 @@ int main(int argc, char *argv[])
{
typedef float Type;

Type object;
Type object = 0.0;
MyAccessor accessor;

ASSERT(bdlat_TypeCategory::e_SIMPLE_CATEGORY
Expand Down Expand Up @@ -1554,7 +1554,7 @@ int main(int argc, char *argv[])
{
typedef int Type;

Type object;
Type object = 0;
MyAccessor accessor;

ASSERT(-1 == bdlat_TypeCategoryFunctions::
Expand Down Expand Up @@ -1583,7 +1583,7 @@ int main(int argc, char *argv[])
{
typedef char Type;

Type object;
Type object = ' ';
MyAccessor accessor;

ASSERT(-1 == bdlat_TypeCategoryFunctions::
Expand Down Expand Up @@ -1612,7 +1612,7 @@ int main(int argc, char *argv[])
{
typedef float Type;

Type object;
Type object = 0.0;
MyAccessor accessor;

ASSERT(-1 == bdlat_TypeCategoryFunctions::
Expand Down Expand Up @@ -2104,7 +2104,7 @@ int main(int argc, char *argv[])
{
typedef int Type;

Type object;
Type object = 0;

ASSERT(bdlat_TypeCategory::e_SIMPLE_CATEGORY
== bdlat_TypeCategoryFunctions::select(object));
Expand All @@ -2113,7 +2113,7 @@ int main(int argc, char *argv[])
{
typedef char Type;

Type object;
Type object = ' ';

ASSERT(bdlat_TypeCategory::e_SIMPLE_CATEGORY
== bdlat_TypeCategoryFunctions::select(object));
Expand All @@ -2122,7 +2122,7 @@ int main(int argc, char *argv[])
{
typedef float Type;

Type object;
Type object = 0.0;

ASSERT(bdlat_TypeCategory::e_SIMPLE_CATEGORY
== bdlat_TypeCategoryFunctions::select(object));
Expand Down
14 changes: 11 additions & 3 deletions groups/bdl/bdlat/bdlat_typename.t.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -45,11 +45,19 @@

#include <bsls_assert.h>
#include <bsls_objectbuffer.h>
#include <bsls_platform.h>
#include <bsls_review.h>

using namespace BloombergLP;
using namespace bsl;

#ifdef BSLS_PLATFORM_HAS_PRAGMA_GCC_DIAGNOSTIC
#ifdef BSLS_PLATFORM_CMP_CLANG
#pragma GCC diagnostic ignored "-Wuninitialized-const-reference"
#pragma GCC diagnostic ignored "-Wunused-private-field"
#endif
#endif

// ============================================================================
// TEST PLAN
// ----------------------------------------------------------------------------
Expand Down Expand Up @@ -258,23 +266,23 @@ bool streq(const char* s1, const char* s2)

#define CLASSNAME_TST(Type, exp) { \
Type object; \
const char *expected = exp ? exp : "<null>"; \
const char *expected = 0 != exp ? exp : "<null>"; \
const char *result = Obj::className(object); \
if (0 == result) result = "<null>"; \
LOOP2_ASSERT(result, expected, streq(result, expected)); \
}

#define NAME_TST(Type, exp) { \
Type object; \
const char *expected = exp ? exp : "<null>"; \
const char *expected = 0 != exp ? exp : "<null>"; \
const char *result = Obj::name(object); \
if (0 == result) result = "<null>"; \
LOOP2_ASSERT(result, expected, streq(result, expected)); \
}

#define XSDNAME_TST(Type, fmt, exp) { \
Type object; \
const char *expected = exp ? exp : "<null>"; \
const char *expected = 0 != exp ? exp : "<null>"; \
const char *result = Obj::xsdName(object, fmt); \
if (0 == result) result = "<null>"; \
LOOP2_ASSERT(result, expected, streq(result, expected)); \
Expand Down
14 changes: 7 additions & 7 deletions groups/bdl/bdlb/bdlb_bitstringimputil.t.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -330,29 +330,29 @@ static uint64_t g(const char *spec)
} break;
case '.': {
if (-1 != rangeStartIndex) {
LOOP2_ASSERT(i, spec[i], G_OFF || !"Multiple Ranges");
LOOP2_ASSERT(i, spec[i], G_OFF || 0 == "Multiple Ranges");
return G_MULTIPLE_RANGES; // RETURN
}
if (0 == bitCount) {
LOOP2_ASSERT(i, spec[i], G_OFF || !"Missing Range Start");
LOOP2_ASSERT(i, spec[i], G_OFF || 0 == "Missing Range Start");
return G_MISSING_RANGE_START; // RETURN
}
while (isspace(spec[++i])) {
// skip whitespace
}
if ('.' != spec[i]) {
LOOP2_ASSERT(i, spec[i], G_OFF || !"Missing Second Dot");
LOOP2_ASSERT(i, spec[i], G_OFF || 0 == "Missing Second Dot");
return G_MISSING_SECOND_DOT; // RETURN
}
while (isspace(spec[++i])) {
// skip whitespace
}
if ('0' != spec[i] && '1' != spec[i]) {
LOOP2_ASSERT(i, spec[i], G_OFF || !"Missing Range End");
LOOP2_ASSERT(i, spec[i], G_OFF || 0 == "Missing Range End");
return G_MISSING_RANGE_END; // RETURN
}
if (spec[i] != spec[lastBitIndex]) {
LOOP2_ASSERT(i, spec[i], G_OFF || !"Nonmatching Range");
LOOP2_ASSERT(i, spec[i], G_OFF || 0 == "Nonmatching Range");
return G_MISMATCHED_RANGE; // RETURN
}

Expand All @@ -363,15 +363,15 @@ static uint64_t g(const char *spec)
} break;
default: {
if (!isspace(spec[i])) {
LOOP2_ASSERT(i, spec[i], G_OFF || !"Illegal Character");
LOOP2_ASSERT(i, spec[i], G_OFF || 0 == "Illegal Character");
return G_ILLEGAL_CHARACTER; // RETURN
}
} break;
}
}

if (bitCount > BITS_PER_UINT64) {
LOOP2_ASSERT(bitCount, BITS_PER_UINT64, G_OFF || !"Too Many Bits");
LOOP2_ASSERT(bitCount, BITS_PER_UINT64, G_OFF || 0 == "Too Many Bits");
return G_TOO_MANY_BITS; // RETURN
}

Expand Down
12 changes: 6 additions & 6 deletions groups/bdl/bdlb/bdlb_nullablevalue.t.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3415,7 +3415,7 @@ void TestDriver<TEST_TYPE>::testCase23_withAllocator()
srcAllocatorPtr = &oa;
} break;
default: {
ASSERTV(CONFIG, !"Bad allocator config.");
ASSERTV(CONFIG, 0 == "Bad allocator config.");
} return; // RETURN
}

Expand Down Expand Up @@ -3521,7 +3521,7 @@ void TestDriver<TEST_TYPE>::testCase23_withAllocator()
srcAllocatorPtr = &oa;
} break;
default: {
ASSERTV(CONFIG, !"Bad allocator config.");
ASSERTV(CONFIG, 0 == "Bad allocator config.");
} return; // RETURN
}
bslma::TestAllocator& sa = *srcAllocatorPtr;
Expand Down Expand Up @@ -3851,7 +3851,7 @@ void TestDriver<TEST_TYPE>::testCase22_withAllocator()
othAllocatorPtr = &da;
} break;
default: {
ASSERTV(CONFIG, !"Bad allocator config.");
ASSERTV(CONFIG, 0 == "Bad allocator config.");
} return; // RETURN
}

Expand Down Expand Up @@ -4210,7 +4210,7 @@ void TestDriver<TEST_TYPE>::testCase21_withAllocator()
srcAllocatorPtr = &oa;
} break;
default: {
ASSERTV(CONFIG, !"Bad allocator config.");
ASSERTV(CONFIG, 0 == "Bad allocator config.");
} return; // RETURN
}
bslma::TestAllocator& sa = *srcAllocatorPtr;
Expand Down Expand Up @@ -4344,7 +4344,7 @@ void TestDriver<TEST_TYPE>::testCase21_withAllocator()
srcAllocatorPtr = &oa;
} break;
default: {
ASSERTV(CONFIG, !"Bad allocator config.");
ASSERTV(CONFIG, 0 == "Bad allocator config.");
} return; // RETURN
}
bslma::TestAllocator& sa = *srcAllocatorPtr;
Expand Down Expand Up @@ -4658,7 +4658,7 @@ void TestDriver<TEST_TYPE>::testCase20_withAllocator()
othAllocatorPtr = &da;
} break;
default: {
ASSERTV(CONFIG, !"Bad allocator config.");
ASSERTV(CONFIG, 0 == "Bad allocator config.");
} return; // RETURN
}

Expand Down
6 changes: 3 additions & 3 deletions groups/bdl/bdlb/bdlb_printmethods.t.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -919,7 +919,7 @@ int main(int argc, char *argv[])
EXPECTED_VALUE = "45";
} break;
default: {
ASSERTV(CONFIG, !"Reachable");
ASSERTV(CONFIG, 0 == "Reachable");
} break;
}

Expand Down Expand Up @@ -1076,7 +1076,7 @@ int main(int argc, char *argv[])
EXPECTED_VALUE = "Six";
} break;
default: {
ASSERTV(CONFIG, !"Reachable");
ASSERTV(CONFIG, 0 == "Reachable");
} break;
}

Expand Down Expand Up @@ -1196,7 +1196,7 @@ int main(int argc, char *argv[])
DFT));
} break;
default: {
ASSERTV(CONFIG, !"Reachable");
ASSERTV(CONFIG, 0 == "Reachable");
} break;
}
}
Expand Down
2 changes: 1 addition & 1 deletion groups/bdl/bdlb/bdlb_stringrefutil.t.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1195,7 +1195,7 @@ int main(int argc, char *argv[])
areSameCaseStrSubstr = true;
} break;
default: {
LOOP_ASSERT(cfg, !"Unknown 'cfg'");
LOOP_ASSERT(cfg, 0 == "Unknown 'cfg'");
} break;
};

Expand Down
2 changes: 1 addition & 1 deletion groups/bdl/bdlb/bdlb_stringviewutil.t.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1521,7 +1521,7 @@ int main(int argc, char *argv[])
areSameCaseStrSubstr = true;
} break;
default: {
LOOP_ASSERT(cfg, !"Unknown 'cfg'");
LOOP_ASSERT(cfg, 0 == "Unknown 'cfg'");
} break;
};

Expand Down
7 changes: 7 additions & 0 deletions groups/bdl/bdlb/bdlb_testinputiterator.t.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,17 @@
#include <bslmf_issame.h> // for testing only

#include <bsls_asserttest.h>
#include <bsls_platform.h>

using namespace BloombergLP;
using namespace bsl;

#ifdef BSLS_PLATFORM_HAS_PRAGMA_GCC_DIAGNOSTIC
#ifdef BSLS_PLATFORM_CMP_CLANG
#pragma GCC diagnostic ignored "-Wself-assign-overloaded"
#endif
#endif

// ============================================================================
// TEST PLAN
// ----------------------------------------------------------------------------
Expand Down
10 changes: 8 additions & 2 deletions groups/bdl/bdlb/bdlb_tokenizer.t.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,19 @@

#include <string> // for 'std::string'

using namespace BloombergLP;
using namespace bsl;

#if defined(BSLS_PLATFORM_CMP_MSVC)
#pragma warning(disable:4553)
#pragma warning(disable:4834)
#endif

using namespace BloombergLP;
using namespace bsl;
#ifdef BSLS_PLATFORM_HAS_PRAGMA_GCC_DIAGNOSTIC
#ifdef BSLS_PLATFORM_CMP_CLANG
#pragma GCC diagnostic ignored "-Wself-assign-overloaded"
#endif
#endif

// ============================================================================
// TEST PLAN
Expand Down
7 changes: 7 additions & 0 deletions groups/bdl/bdlb/bdlb_transformiterator.t.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@

#include <bsls_asserttest.h>
#include <bsls_nameof.h>
#include <bsls_platform.h>

#include <bsl_algorithm.h>
#include <bsl_cmath.h>
Expand All @@ -23,6 +24,12 @@ using namespace BloombergLP;
using namespace bdlb;
using namespace bsl;

#ifdef BSLS_PLATFORM_HAS_PRAGMA_GCC_DIAGNOSTIC
#ifdef BSLS_PLATFORM_CMP_CLANG
#pragma GCC diagnostic ignored "-Wmissing-braces"
#endif
#endif

// ============================================================================
// TEST PLAN
// ----------------------------------------------------------------------------
Expand Down
Loading

0 comments on commit 9b27510

Please sign in to comment.