reduce warnings (#4817)

* reduce warnings * changes caused compile errors, reverting
bloomberg · Jul 8, 2024 · b662fc9 · b662fc9
1 parent 8587aa2
commit b662fc9
Show file tree

Hide file tree

Showing 16 changed files with 73 additions and 49 deletions.
diff --git a/groups/bal/balber/balber_beruniversaltagnumber.t.cpp b/groups/bal/balber/balber_beruniversaltagnumber.t.cpp
@@ -35,9 +35,11 @@
 #include <bslma_allocator.h>
 #include <bslma_default.h>
 #include <bslmf_conditional.h>
+
 #include <bsls_assert.h>
 #include <bsls_asserttest.h>
 #include <bsls_objectbuffer.h>
+#include <bsls_platform.h>
 #include <bsls_types.h>
 
 #include <bsl_iosfwd.h>
@@ -56,6 +58,12 @@ using bsl::ends;
 using bsl::flush;
 namespace test = BloombergLP::s_baltst;
 
+#ifdef BSLS_PLATFORM_HAS_PRAGMA_GCC_DIAGNOSTIC
+#ifdef BSLS_PLATFORM_CMP_CLANG
+#pragma GCC diagnostic ignored "-Wuninitialized-const-reference"
+#endif
+#endif
+
 // ============================================================================
 //                                 TEST PLAN
 // ----------------------------------------------------------------------------

diff --git a/groups/bal/ball/ball_recordjsonformatter.t.cpp b/groups/bal/ball/ball_recordjsonformatter.t.cpp
@@ -2146,12 +2146,12 @@ int main(int argc, char *argv[])
 
             ASSERTV(LINE, SPEC, SPEC == X.format());
             ASSERTV(LINE, RSEP, RSEP == X.recordSeparator());
-#ifdef BSLS_PLATFORM_CMP_GNU
+#ifdef BSLS_PLATFORM_HAS_PRAGMA_GCC_DIAGNOSTIC
 # pragma GCC diagnostic push
 # pragma GCC diagnostic ignored "-Wdeprecated-declarations"
 #endif
             ASSERTV(LINE, SPEC, &oa == X.allocator());
-#ifdef BSLS_PLATFORM_CMP_GNU
+#ifdef BSLS_PLATFORM_HAS_PRAGMA_GCC_DIAGNOSTIC
 # pragma GCC diagnostic pop
 #endif
             ASSERTV(LINE, SPEC, &oa == X.get_allocator());

diff --git a/groups/bal/balm/balm_collector.t.cpp b/groups/bal/balm/balm_collector.t.cpp
@@ -114,10 +114,9 @@ class ConcurrencyTest {
     // Invoke a set of operations operations synchronously.
 
     // DATA
-    bdlmt::FixedThreadPool              d_pool;
-    bslmt::Barrier                      d_barrier;
-    balm::Collector                    *d_collector_p;
-    BSLA_MAYBE_UNUSED bslma::Allocator *d_allocator_p;
+    bdlmt::FixedThreadPool  d_pool;
+    bslmt::Barrier          d_barrier;
+    balm::Collector        *d_collector_p;
 
     // PRIVATE MANIPULATORS
     void execute();
@@ -132,7 +131,6 @@ class ConcurrencyTest {
     : d_pool(numThreads, 1000, basicAllocator)
     , d_barrier(numThreads)
     , d_collector_p(collector)
-    , d_allocator_p(basicAllocator)
     {
         d_pool.start();
     }

diff --git a/groups/bal/balm/balm_integercollector.t.cpp b/groups/bal/balm/balm_integercollector.t.cpp
@@ -111,10 +111,9 @@ class ConcurrencyTest {
     // Invoke a set of operations operations synchronously.
 
     // DATA
-    bdlmt::FixedThreadPool              d_pool;
-    bslmt::Barrier                      d_barrier;
-    balm::IntegerCollector             *d_collector_p;
-    BSLA_MAYBE_UNUSED bslma::Allocator *d_allocator_p;
+    bdlmt::FixedThreadPool  d_pool;
+    bslmt::Barrier          d_barrier;
+    balm::IntegerCollector *d_collector_p;
 
     // PRIVATE MANIPULATORS
     void execute();
@@ -129,7 +128,6 @@ class ConcurrencyTest {
     : d_pool(numThreads, 1000, basicAllocator)
     , d_barrier(numThreads)
     , d_collector_p(collector)
-    , d_allocator_p(basicAllocator)
     {
         d_pool.start();
     }

diff --git a/groups/bal/balm/balm_integermetric.t.cpp b/groups/bal/balm/balm_integermetric.t.cpp
@@ -154,11 +154,10 @@ class MetricConcurrencyTest {
     // Invoke a set of operations operations synchronously.
 
     // DATA
-    bdlmt::FixedThreadPool              d_pool;
-    balm::IntegerMetric                *d_metric;
-    balm::MetricRegistry               *d_registry;
-    bslmt::Barrier                      d_barrier;
-    BSLA_MAYBE_UNUSED bslma::Allocator *d_allocator_p;
+    bdlmt::FixedThreadPool  d_pool;
+    balm::IntegerMetric    *d_metric;
+    balm::MetricRegistry   *d_registry;
+    bslmt::Barrier          d_barrier;
 
     // PRIVATE MANIPULATORS
     void execute();
@@ -175,7 +174,6 @@ class MetricConcurrencyTest {
     , d_metric(metric)
     , d_registry(registry)
     , d_barrier(numThreads)
-    , d_allocator_p(basicAllocator)
     {
         d_pool.start();
     }

diff --git a/groups/bal/balm/balm_metric.t.cpp b/groups/bal/balm/balm_metric.t.cpp
@@ -151,11 +151,10 @@ class MetricConcurrencyTest {
     // Invoke a set of operations operations synchronously.
 
     // DATA
-    bdlmt::FixedThreadPool              d_pool;
-    balm::Metric                       *d_metric;
-    balm::MetricRegistry               *d_registry;
-    bslmt::Barrier                      d_barrier;
-    BSLA_MAYBE_UNUSED bslma::Allocator *d_allocator_p;
+    bdlmt::FixedThreadPool  d_pool;
+    balm::Metric           *d_metric;
+    balm::MetricRegistry   *d_registry;
+    bslmt::Barrier          d_barrier;
 
     // PRIVATE MANIPULATORS
     void execute();
@@ -172,7 +171,6 @@ class MetricConcurrencyTest {
     , d_metric(metric)
     , d_registry(registry)
     , d_barrier(numThreads)
-    , d_allocator_p(basicAllocator)
     {
         d_pool.start();
     }

diff --git a/groups/bal/balm/balm_metricformat.t.cpp b/groups/bal/balm/balm_metricformat.t.cpp
@@ -6,10 +6,13 @@
 #include <bdlf_bind.h>
 
 #include <bslim_testutil.h>
+
 #include <bslma_allocator.h>
 #include <bslma_defaultallocatorguard.h>
 #include <bslma_testallocator.h>
+
 #include <bsls_assert.h>
+#include <bsls_platform.h>
 
 #include <bsl_iostream.h>
 #include <bsl_ostream.h>
@@ -25,6 +28,12 @@ using bsl::cout;
 using bsl::endl;
 using bsl::flush;
 
+#ifdef BSLS_PLATFORM_HAS_PRAGMA_GCC_DIAGNOSTIC
+#ifdef BSLS_PLATFORM_CMP_CLANG
+#pragma GCC diagnostic ignored "-Wself-assign-overloaded"
+#endif
+#endif
+
 // ============================================================================
 //                                 TEST PLAN
 // ----------------------------------------------------------------------------

diff --git a/groups/bal/balm/balm_metricrecord.t.cpp b/groups/bal/balm/balm_metricrecord.t.cpp
@@ -3,6 +3,8 @@
 
 #include <bslim_testutil.h>
 
+#include <bsls_platform.h>
+
 #include <bsl_algorithm.h>
 #include <bsl_iostream.h>
 #include <bsl_ostream.h>
@@ -18,6 +20,12 @@ using bsl::cout;
 using bsl::endl;
 using bsl::flush;
 
+#ifdef BSLS_PLATFORM_HAS_PRAGMA_GCC_DIAGNOSTIC
+#ifdef BSLS_PLATFORM_CMP_CLANG
+#pragma GCC diagnostic ignored "-Wself-assign-overloaded"
+#endif
+#endif
+
 // ============================================================================
 //                                  TEST PLAN
 // ----------------------------------------------------------------------------

diff --git a/groups/bal/balm/balm_metrics.t.cpp b/groups/bal/balm/balm_metrics.t.cpp
@@ -347,7 +347,6 @@ class StandardMacroConcurrencyTest {
     // DATA
     Corp::bdlmt::FixedThreadPool  d_pool;
     Corp::bslmt::Barrier          d_barrier;
-    Corp::bslma::Allocator       *d_allocator_p;
 
     // PRIVATE MANIPULATORS
     void execute();
@@ -360,7 +359,6 @@ class StandardMacroConcurrencyTest {
                                  Corp::bslma::Allocator *basicAllocator)
     : d_pool(numThreads, 1000, basicAllocator)
     , d_barrier(numThreads)
-    , d_allocator_p(basicAllocator)
     {
         d_pool.start();
     }
@@ -494,7 +492,6 @@ class DynamicMacroConcurrencyTest {
     // DATA
     Corp::bdlmt::FixedThreadPool  d_pool;
     Corp::bslmt::Barrier          d_barrier;
-    Corp::bslma::Allocator       *d_allocator_p;
 
     // PRIVATE MANIPULATORS
     void execute();
@@ -506,7 +503,6 @@ class DynamicMacroConcurrencyTest {
                                 Corp::bslma::Allocator *basicAllocator)
     : d_pool(numThreads, 1000, basicAllocator)
     , d_barrier(numThreads)
-    , d_allocator_p(basicAllocator)
     {
         d_pool.start();
     }
@@ -802,7 +798,6 @@ class StandardIntMacroConcurrencyTest {
     // DATA
     Corp::bdlmt::FixedThreadPool   d_pool;
     Corp::bslmt::Barrier           d_barrier;
-    Corp::bslma::Allocator        *d_allocator_p;
 
     // PRIVATE MANIPULATORS
     void execute();
@@ -815,7 +810,6 @@ class StandardIntMacroConcurrencyTest {
                                     Corp::bslma::Allocator *basicAllocator)
     : d_pool(numThreads, 1000, basicAllocator)
     , d_barrier(numThreads)
-    , d_allocator_p(basicAllocator)
     {
         d_pool.start();
     }
@@ -950,7 +944,6 @@ class DynamicIntMacroConcurrencyTest {
     // DATA
     Corp::bdlmt::FixedThreadPool  d_pool;
     Corp::bslmt::Barrier          d_barrier;
-    Corp::bslma::Allocator       *d_allocator_p;
 
     // PRIVATE MANIPULATORS
     void execute();
@@ -962,7 +955,6 @@ class DynamicIntMacroConcurrencyTest {
                                    Corp::bslma::Allocator *basicAllocator)
     : d_pool(numThreads, 1000, basicAllocator)
     , d_barrier(numThreads)
-    , d_allocator_p(basicAllocator)
     {
         d_pool.start();
     }

diff --git a/groups/bal/balm/balm_metricsample.t.cpp b/groups/bal/balm/balm_metricsample.t.cpp
@@ -5,9 +5,12 @@
 #include <bdlt_dateutil.h>
 
 #include <bslim_testutil.h>
+
 #include <bslma_defaultallocatorguard.h>
 #include <bslma_testallocator.h>
+
 #include <bsls_assert.h>
+#include <bsls_platform.h>
 
 #include <bsl_cstddef.h>
 #include <bsl_cstdlib.h>
@@ -23,6 +26,12 @@ using bsl::cout;
 using bsl::endl;
 using bsl::flush;
 
+#ifdef BSLS_PLATFORM_HAS_PRAGMA_GCC_DIAGNOSTIC
+#ifdef BSLS_PLATFORM_CMP_CLANG
+#pragma GCC diagnostic ignored "-Wself-assign-overloaded"
+#endif
+#endif
+
 // ============================================================================
 //                                  TEST PLAN
 // ----------------------------------------------------------------------------

diff --git a/groups/bal/balm/balm_metricsmanager.t.cpp b/groups/bal/balm/balm_metricsmanager.t.cpp
@@ -2053,7 +2053,7 @@ int main(int argc, char *argv[])
 
         const char *CATEGORIES[] = {"A", "B", "C", "Test", "12312category"};
         const int   NUM_CATEGORIES = sizeof (CATEGORIES)/sizeof (*CATEGORIES);
-        const char *METRICS[] = { "A", "B", "C", "MyMetric" "90123metric" };
+        const char *METRICS[] = { "A", "B", "C", "MyMetric", "90123metric" };
         const int   NUM_METRICS = sizeof (METRICS) / sizeof (*METRICS);
 
         typedef bsl::shared_ptr<TestCallback> CbPtr;
@@ -2119,7 +2119,7 @@ int main(int argc, char *argv[])
 
         const char *CATEGORIES[] = {"A", "B", "C", "Test", "12312category"};
         const int   NUM_CATEGORIES = sizeof (CATEGORIES)/sizeof (*CATEGORIES);
-        const char *METRICS[] = { "A", "B", "C", "MyMetric" "90123metric" };
+        const char *METRICS[] = { "A", "B", "C", "MyMetric", "90123metric" };
         const int NUM_METRICS = sizeof (METRICS) / sizeof (*METRICS);
 
         // Create a map, from metric id to 'TestCallback' functor.
@@ -2357,7 +2357,7 @@ int main(int argc, char *argv[])
 
         const char *CATEGORIES[] = {"A", "B", "C", "Test", "12312category"};
         const int   NUM_CATEGORIES = sizeof (CATEGORIES)/sizeof (*CATEGORIES);
-        const char *METRICS[] = { "A", "B", "C", "MyMetric" "90123metric" };
+        const char *METRICS[] = { "A", "B", "C", "MyMetric", "90123metric" };
         const int NUM_METRICS = sizeof (METRICS) / sizeof (*METRICS);
 
         // Create a map, from metric id to 'TestCallback' functor.
@@ -3771,7 +3771,7 @@ int main(int argc, char *argv[])
 
         const char *CATEGORIES[] = {"A", "B", "C", "Test", "12312category"};
         const int   NUM_CATEGORIES = sizeof (CATEGORIES)/sizeof (*CATEGORIES);
-        const char *METRICS[] = { "A", "B", "C", "MyMetric" "90123metric" };
+        const char *METRICS[] = { "A", "B", "C", "MyMetric", "90123metric" };
         const int NUM_METRICS = sizeof (METRICS) / sizeof (*METRICS);
 
         // Create a map, from metric id to 'TestCallback' functor.

diff --git a/groups/bal/balst/balst_stacktraceframe.t.cpp b/groups/bal/balst/balst_stacktraceframe.t.cpp
@@ -1865,7 +1865,7 @@ int main(int argc, char *argv[])
                         objAllocatorPtr = &sa;
                       } break;
                       default: {
-                        LOOP_ASSERT(CONFIG, !"Bad allocator config.");
+                        LOOP_ASSERT(CONFIG, 0 == "Bad allocator config.");
                         continue;
                       } break;
                     }
@@ -3250,7 +3250,7 @@ int main(int argc, char *argv[])
                         objAllocatorPtr = &sa;
                       } break;
                       default: {
-                        LOOP2_ASSERT(LINE, CONFIG, !"Bad allocator config.");
+                        LOOP2_ASSERT(LINE, CONFIG, 0 == "Bad allocator config.");
                         continue;
                       } break;
                     }
@@ -3674,7 +3674,7 @@ int main(int argc, char *argv[])
                 objAllocatorPtr = &sa;
               } break;
               default: {
-                LOOP_ASSERT(CONFIG, !"Bad allocator config.");
+                LOOP_ASSERT(CONFIG, 0 == "Bad allocator config.");
                 continue;
               } break;
             }

diff --git a/groups/bal/baltzo/baltzo_datafileloader.t.cpp b/groups/bal/baltzo/baltzo_datafileloader.t.cpp
@@ -1350,7 +1350,7 @@ int main(int argc, char *argv[])
                 objAllocatorPtr = &sa;
               } break;
               default: {
-                LOOP_ASSERT(CONFIG, !"Bad allocator Config.");
+                LOOP_ASSERT(CONFIG, 0 == "Bad allocator Config.");
               } break;
             }
 

diff --git a/groups/bal/baltzo/baltzo_localtimeperiod.t.cpp b/groups/bal/baltzo/baltzo_localtimeperiod.t.cpp
@@ -1039,7 +1039,7 @@ int main(int argc, char *argv[])
                         done = true;
                       } break;
                       default: {
-                        ASSERTV(CONFIG, !"Bad allocator config.");
+                        ASSERTV(CONFIG, 0 == "Bad allocator config.");
                       } break;
                     }
                     ASSERTV(LINE, CONFIG,
@@ -2414,7 +2414,7 @@ int main(int argc, char *argv[])
                         objAllocatorPtr = &sa;
                       } break;
                       default: {
-                        LOOP_ASSERT(CONFIG, !"Bad allocator config.");
+                        LOOP_ASSERT(CONFIG, 0 == "Bad allocator config.");
                       } break;
                     }
                     LOOP2_ASSERT(LINE, CONFIG,
@@ -3532,7 +3532,7 @@ int main(int argc, char *argv[])
                         objAllocatorPtr = &sa;
                       } break;
                       default: {
-                        LOOP2_ASSERT(LINE, CONFIG, !"Bad allocator config.");
+                        LOOP2_ASSERT(LINE, CONFIG, 0 == "Bad allocator config.");
                       } break;
                     }
                     LOOP2_ASSERT(LINE, CONFIG,
@@ -3875,7 +3875,7 @@ int main(int argc, char *argv[])
                 objAllocatorPtr = &sa;
               } break;
               default: {
-                LOOP_ASSERT(CONFIG, !"Bad allocator config.");
+                LOOP_ASSERT(CONFIG, 0 == "Bad allocator config.");
               } break;
             }
 

diff --git a/groups/bal/baltzo/baltzo_timezoneutil.t.cpp b/groups/bal/baltzo/baltzo_timezoneutil.t.cpp
@@ -2957,7 +2957,7 @@ int main(int argc, char *argv[])
                                                              TZID));
                       } break;
                       default: {
-                        LOOP2_ASSERT(LINE, CONFIG, !"Bad test config.");
+                        LOOP2_ASSERT(LINE, CONFIG, 0 == "Bad test config.");
                       } break;
                     }