Fix more Wconversion warnings #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
678098
reviewed
Oct 9, 2023
| @@ -47,7 +47,7 @@ void TestHelper::printTestName(bslstl::StringRef value) | |||
| } | |||
|
|
|||
| bsl::cout << "\n" << value << "\n"; | |||
| int length = value.length(); | |||
There was a problem hiding this comment.
Currently long unsigned int is identical to size_t, but for the future it's more safe to use size_t here, as length() returns. The reason is that size_t has an explicit contract in its definition size_t can store the maximum size of a theoretically possible object of any type (including array).
https://en.cppreference.com/w/c/types/size_t
There are size_t used in almost all similar cases in the codebase.
There was a problem hiding this comment.
Addressed, thanks!
Signed-off-by: banipreetr <[email protected]>
Signed-off-by: banipreetr <[email protected]>
banipreetr
force-pushed
the
wconversion-warns
branch
from
91545cf to
7a7c8b2
Compare
|
@banipreetr thank you for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*Issue number of the reported bug or feature request: #87 *
Describe your changes
Follow up to #122, this PR contribution is to fix more -Wconversion warnings that pollutes the build log.
Testing performed
N/A
Additional context
Add any other context about your contribution here.