Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: m_bmqtool::Poster: remove unsafe format string passed #603

Merged
merged 5 commits into from
Feb 7, 2025
Merged

Fix: m_bmqtool::Poster: remove unsafe format string passed #603

merged 5 commits into from
Feb 7, 2025

Conversation

sameep-git
Copy link
Contributor

Closes: #593

  1. We remove sequentialMessagePattern from being passed as a format string by appending it with a mutable suffix for d_numMessagesPosted.
  2. Remove the need for %d in the integration test file test_puts_retransmission.py.

@sameep-git sameep-git requested a review from a team as a code owner February 7, 2025 04:38
@sameep-git @678098
Update src/integration-tests/test_puts_retransmission.py
f23c795 
Co-authored-by: Evgeny Malygin <[email protected]>
Signed-off-by: Sameep Shah <[email protected]>
678098
678098 approved these changes Feb 7, 2025
View reviewed changes
Copy link
Collaborator

@678098 678098 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @sameep-git!

@678098 678098 merged commit 665144f into bloomberg:main Feb 7, 2025
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@678098 678098 678098 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bmqtool: fix possibly unsafe format string passing
2 participants
@sameep-git @678098