Refactor[BMQ,MQB,CI]: various improvements #604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
678098
commented
Feb 10, 2025
•
678098
commented
- Allows to run ITs on Solaris
- Use typing hints compatible with legacy Python versions
- Remove outdated modules log configuration
- Better naming for variables
- Fix missing cores dir case
678098
force-pushed
the
250207_refactor_fixes
branch
from
aa7d86b to
08f9cf2
Compare
Signed-off-by: Evgeny Malygin <[email protected]>
678098
force-pushed
the
250207_refactor_fixes
branch
from
08f9cf2 to
6fa3eb2
Compare
678098
commented
Feb 10, 2025
| "core pattern '%s' does not contain process id, cores will not be saved", | ||
| pattern, | ||
| ) | ||
| except FileExistsError: |
There was a problem hiding this comment.
This was a wrong type of error
678098
commented
Feb 10, 2025
| @@ -64,7 +64,7 @@ def post_n_msgs( | |||
| for _ in range(task.num): | |||
| res = producer.post(task.uri, payload=["msg"], wait_ack=True) | |||
| assert Client.e_SUCCESS == res | |||
| producer.close(task.uri) | |||
| producer.close(task.uri, succeed=True) | |||
There was a problem hiding this comment.
This close was nonblocking, it was possible to execute the next command before producer was actually closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.