Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Perf[MQB]: cache support for MESSAGE_PROPERTIES_EX on PUSH path #607

Merged
merged 1 commit into from
Feb 12, 2025
Merged

Perf[MQB]: cache support for MESSAGE_PROPERTIES_EX on PUSH path #607

merged 1 commit into from
Feb 12, 2025
+11 −4

Conversation

678098
Copy link
Collaborator

@678098 678098 commented Feb 12, 2025 •
edited
Loading

This PR gets rid of the repeated bmqp::ProtocolUtil::hasFeature calls per every PUSH message.

In this listing, ~2% of all CPU time is lost on these calls:

Screenshot 2025-02-12 at 19 04 39

@678098 678098 requested a review from a team as a code owner February 12, 2025 19:17
@678098 678098 requested review from dorjesinpo and removed request for a team February 12, 2025 19:18
dorjesinpo
dorjesinpo approved these changes Feb 12, 2025
View reviewed changes
Copy link
Collaborator

@dorjesinpo dorjesinpo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@678098 678098 merged commit 85652ff into bloomberg:main Feb 12, 2025
30 of 31 checks passed
@678098 678098 deleted the 250212_opt_legacy_features_read branch February 12, 2025 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dorjesinpo dorjesinpo dorjesinpo approved these changes

Assignees

@dorjesinpo dorjesinpo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@678098 @dorjesinpo