Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use libcdb2api.a instead of libcdb2api.so #50

Closed

Conversation

sarahmonod
Copy link
Contributor

@sarahmonod sarahmonod commented Nov 15, 2023

This will make it easier if and when we decide to publish wheels, and
will also fix our CI by ensuring that (almost) all dependencies are
built statically within _ccdb2.so.

Signed-off-by: Gus Monod [email protected]

@sarahmonod sarahmonod force-pushed the switch-to-static-cdbapi2 branch 2 times, most recently from e4976a2 to b83e02c Compare November 15, 2023 21:57
This will make it easier if and when we decide to publish wheels, and
will also fix our CI by ensuring that (almost) all dependencies are
built statically within `_ccdb2.so`.

Signed-off-by: Gus Monod <[email protected]>
@sarahmonod sarahmonod force-pushed the switch-to-static-cdbapi2 branch 2 times, most recently from 6aa8ce9 to 9061598 Compare November 20, 2023 21:09
@sarahmonod sarahmonod marked this pull request as ready for review November 20, 2023 21:43
@sarahmonod sarahmonod requested a review from godlygeek November 20, 2023 22:22
@sarahmonod
Copy link
Contributor Author

The level of support for libcdb2api.a seems to be on par with that of libcdb2api.so after all, so this isn't necessary.

Considering that libunwind.so and libprotobuf-c.so still get loaded dynamically, and that auditwheel can vendor the *.so files properly, this doesn't really help.

@sarahmonod sarahmonod closed this Nov 20, 2023
@sarahmonod sarahmonod deleted the switch-to-static-cdbapi2 branch November 20, 2023 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant