Drop support for Python 3.7, and fix CI on Ubuntu 24.04 #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
godlygeek
force-pushed
the
comdb2_depends_on_libuuid
branch
2 times, most recently
from
bc38825 to
701502c
Compare
gaborbernat
approved these changes
Jan 15, 2025
godlygeek
force-pushed
the
comdb2_depends_on_libuuid
branch
3 times, most recently
from
f585bfb to
4b2dd5a
Compare
godlygeek
changed the title
godlygeek
force-pushed
the
comdb2_depends_on_libuuid
branch
3 times, most recently
from
5d21bec to
465640f
Compare
Previously we were sharing the Comdb2 build directory, but this didn't work entirely as intended, as the `make install` step could detect that some files needed to be rebuilt. Instead, run the `make install` once, and copy around the installed files. Signed-off-by: Matt Wozniski <[email protected]>
Signed-off-by: Matt Wozniski <[email protected]>
godlygeek
force-pushed
the
comdb2_depends_on_libuuid
branch
from
465640f to
6d8cf8f
Compare
gaborbernat
approved these changes
Jan 15, 2025
sarahmonod
reviewed
Jan 15, 2025
sarahmonod
approved these changes
Jan 15, 2025
Now that there has been a 3.13 final release, "3.13" and "3.13-dev" are equivalent. Signed-off-by: Matt Wozniski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI has been upgraded to run on Ubuntu 24.04. Rather than pin to 22.04, get things working instead. This necessitates dropping support for Python 3.7, as
actions/setup-pythondoes not support Python 3.7 on Ubuntu 24.04.