added missing else which caused redundant memory access for 512-bit l…

…oads
bochs-emu · Nov 18, 2023 · 8608283 · 8608283
1 parent 054767f
commit 8608283
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/bochs/cpu/load.cc b/bochs/cpu/load.cc
@@ -443,7 +443,7 @@ void BX_CPP_AttrRegparmN(1) BX_CPU_C::LOAD_BROADCAST_VectorD(bxInstruction_c *i)
   else {
     if (len == BX_VL512)
       read_virtual_zmmword(i->seg(), eaddr, &BX_READ_AVX_REG(BX_VECTOR_TMP_REGISTER));
-    if (len == BX_VL256)
+    else if (len == BX_VL256)
       read_virtual_ymmword(i->seg(), eaddr, &BX_READ_YMM_REG(BX_VECTOR_TMP_REGISTER));
     else
       read_virtual_xmmword(i->seg(), eaddr, &BX_READ_XMM_REG(BX_VECTOR_TMP_REGISTER));
@@ -490,7 +490,7 @@ void BX_CPP_AttrRegparmN(1) BX_CPU_C::LOAD_BROADCAST_VectorQ(bxInstruction_c *i)
   else {
     if (len == BX_VL512)
       read_virtual_zmmword(i->seg(), eaddr, &BX_READ_AVX_REG(BX_VECTOR_TMP_REGISTER));
-    if (len == BX_VL256)
+    else if (len == BX_VL256)
       read_virtual_ymmword(i->seg(), eaddr, &BX_READ_YMM_REG(BX_VECTOR_TMP_REGISTER));
     else
       read_virtual_xmmword(i->seg(), eaddr, &BX_READ_XMM_REG(BX_VECTOR_TMP_REGISTER));
@@ -538,7 +538,7 @@ void BX_CPP_AttrRegparmN(1) BX_CPU_C::LOAD_BROADCAST_Half_VectorD(bxInstruction_
     if (len == BX_VL512) {
       read_virtual_ymmword(i->seg(), eaddr, &BX_READ_YMM_REG(BX_VECTOR_TMP_REGISTER));
     }
-    if (len == BX_VL256) {
+    else if (len == BX_VL256) {
       read_virtual_xmmword(i->seg(), eaddr, &BX_READ_XMM_REG(BX_VECTOR_TMP_REGISTER));
     }
     else {