Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved and enhanced the floppy emulation #135

Merged
merged 8 commits into from
Nov 21, 2023
Merged

Conversation

fysnet
Copy link
Collaborator

@fysnet fysnet commented Nov 16, 2023

This improves and enhances the floppy emulation.
This adds the ability to specify a controller type.
This adds all but one, known, controller command.
This fixes the format command. Issue #123
This fixes the error with older Windows guests.

@fysnet fysnet marked this pull request as ready for review November 16, 2023 02:17
@stlintel
Copy link
Contributor

Volker, Ben - what is the testing / level of confidence needed to merge it ?
I am not a person to decide here, can only approve and merge when ready

stlintel
stlintel previously approved these changes Nov 20, 2023
@stlintel
Copy link
Contributor

BTW, Ben - do you have access to 'Squash and merge' button ?

@fysnet
Copy link
Collaborator Author

fysnet commented Nov 20, 2023

Volker, Ben - what is the testing / level of confidence needed to merge it ? I am not a person to decide here, can only approve and merge when ready

I tested all floppy sizes with DOS and FreeDOS, most sizes with Win98 and Win2k, and all sizes above 360k with WinXP. I know the that Scan functions may or may not be correct, though I have no way of testing them other than my own code. I know of no Guest that supports these functions. Every physical hardware I tested with, even though the specifications say the Scan functions are supported with that hardware, return "illegal command".

It would be good if Volker can make a few tests too (please), but I feel confident to merge.

BTW, Ben - do you have access to 'Squash and merge' button ?

I do not have access to either. It still says:

Only those with write access to this repository can merge pull requests.

Thanks,
Ben

@fysnet
Copy link
Collaborator Author

fysnet commented Nov 21, 2023

I added a few very minor fixes and cleanups. This should be it, ready for merging. Thanks.

@stlintel stlintel merged commit 01a2623 into bochs-emu:master Nov 21, 2023
1 check passed
@fysnet fysnet deleted the floppy branch November 21, 2023 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants