Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memory corruption when reading Voodoo ROM #169

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

Vort
Copy link
Contributor

@Vort Vort commented Dec 15, 2023

Fixes #131.

@Vort
Copy link
Contributor Author

Vort commented Dec 15, 2023

I took idea of how to handle len = 3 reads from

case 8:
*((Bit32u *) ((Bit8u *) data + 4)) = val_hi;
case 4:
*((Bit32u *) data) = val;
break;

After further thought, doubts about whether this code will work correctly on big-endian architectures appeared.
However I have no access to such machines, so I can't test it.

@stlintel stlintel merged commit 30db11d into bochs-emu:master Dec 15, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash of Bochs / OS with default Voodoo 3 drivers
2 participants