Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FE][Feat] #30 : DrawRoute 페이지 초안 #170

Closed
wants to merge 4 commits into from

Conversation

juwon5272
Copy link
Collaborator

📝 PR 개요

  • DrawRoute 페이지 초안
  • 선그리기 기능 (LineDrawer) 초안

🔍 변경 사항

  • LineDrawer
    • canvas를 지도의 크기에 딱 맞게 하는 함수 추가 예정
    • 지우개 기능 추가 예정
  • DrawRoute 페이지
    • Header 완성시 Header로 교체

✅ 체크리스트 (Checklist)

  • 코드가 빌드 오류 없이 잘 작동하는지 확인
  • 테스트가 통과하는지 확인
  • 스타일 가이드와 일관성을 유지했는지 확인

📷 스크린샷 및 동영상 (선택 사항)

2024-11-14.4.02.56.mov

@github-actions github-actions bot added the 확인 요청 리뷰어에게 리뷰 요청 PR 날린 상태 (PR 머지 전) label Nov 14, 2024
@juwon5272 juwon5272 changed the title [FE][Feat] #30 : Main 페이지 [FE][Feat] #30 : DrawRoute 페이지 초안 Nov 14, 2024
leedongyull
leedongyull previously approved these changes Nov 14, 2024
frontend/src/pages/Main.tsx Show resolved Hide resolved
@juwon5272 juwon5272 dismissed leedongyull’s stale review November 14, 2024 09:38

The merge-base changed after approval.

happyhyep
happyhyep previously approved these changes Nov 14, 2024
Copy link
Member

@happyhyep happyhyep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@effozen effozen self-requested a review November 14, 2024 09:40
@effozen effozen requested a review from leedongyull November 14, 2024 09:41
leedongyull
leedongyull previously approved these changes Nov 14, 2024
effozen
effozen previously approved these changes Nov 14, 2024
@juwon5272 juwon5272 removed the 확인 요청 리뷰어에게 리뷰 요청 PR 날린 상태 (PR 머지 전) label Nov 14, 2024
@effozen effozen added the 작업 완료 PR이 제대로 되어 approve 된 상태 (PR 받은 두명 중 마지막 사람이 상태 변경) label Nov 14, 2024
@github-actions github-actions bot added the 확인 요청 리뷰어에게 리뷰 요청 PR 날린 상태 (PR 머지 전) label Nov 14, 2024
@juwon5272 juwon5272 dismissed stale reviews from effozen, leedongyull, and happyhyep November 14, 2024 09:43

The merge-base changed after approval.

@effozen effozen removed the 작업 완료 PR이 제대로 되어 approve 된 상태 (PR 받은 두명 중 마지막 사람이 상태 변경) label Nov 14, 2024
@effozen effozen self-requested a review November 14, 2024 09:44
@juwon5272 juwon5272 removed the request for review from effozen November 14, 2024 09:44
@effozen effozen requested review from effozen and removed request for happyhyep November 14, 2024 09:44
@juwon5272 juwon5272 closed this Nov 14, 2024
@effozen effozen deleted the feature/fe/#4-linedrawer branch December 5, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
확인 요청 리뷰어에게 리뷰 요청 PR 날린 상태 (PR 머지 전)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants