refactor: 2번 문제 early return으로 로직 수정

[#152]
boostcampwm2023 · Nov 30, 2023 · ca70d2a · ca70d2a
1 parent ffc1c85
commit ca70d2a
Showing 1 changed file with 8 additions and 4 deletions.
diff --git a/packages/backend/src/quiz-wizard/quiz-wizard.service.ts b/packages/backend/src/quiz-wizard/quiz-wizard.service.ts
@@ -27,11 +27,15 @@ export class QuizWizardService {
   }
 
   async checkCondition2(containerId: string): Promise<boolean> {
-    return !(
-      (await this.magic.getConfig(containerId, 'name')) === 'MergeMaster' ||
+    if ((await this.magic.getConfig(containerId, 'name')) === 'MergeMaster')
+      return false;
+    if (
       (await this.magic.getConfig(containerId, 'email')) ===
-        '[email protected]'
-    );
+      '[email protected]'
+    )
+      return false;
+
+    return true;
   }
 
   async checkCondition3(containerId: string): Promise<boolean> {