Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pending cleanups and fixes #3526

Merged
merged 4 commits into from
Jan 28, 2025
Merged

Pending cleanups and fixes #3526

merged 4 commits into from
Jan 28, 2025

Conversation

niwsa
Copy link
Member

@niwsa niwsa commented Jan 22, 2025

What does this PR do?

  • Use logger instead of console
  • Hide internal errors in SAML Fed request path

Type of change

  • Updated dependencies
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How should this be tested?

  • Existing unit tests

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code and corrected any misspellings
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@niwsa niwsa marked this pull request as ready for review January 28, 2025 11:17
@niwsa niwsa requested a review from a team January 28, 2025 11:17
@deepakprabhakara deepakprabhakara merged commit 497200b into main Jan 28, 2025
5 checks passed
@deepakprabhakara deepakprabhakara deleted the cleanup branch January 28, 2025 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants