Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically resize text areas (+ text fields that can be multi-line) #713

Closed
nikku opened this issue Jul 1, 2022 · 5 comments · Fixed by #1068
Closed

Automatically resize text areas (+ text fields that can be multi-line) #713

nikku opened this issue Jul 1, 2022 · 5 comments · Fixed by #1068
Assignees
Labels
enhancement New feature or request needs more information Requires additional information to be actionable. ux

Comments

@nikku
Copy link
Member

nikku commented Jul 1, 2022

Is your feature request related to a problem? Please describe

As a user I'm often editing text that may be multi-line (or single line).

I'm struggling to use the properties panel as the text input controls don't work intuitive for me:

  • Text areas are not sized by content but instead fixed to three lines. This is too much for no content, but not enough for any reasonable amount of text
  • Text fields (i.e. Name) can sometimes be multi-line. I'd expect them to be single line per default but expand sensibly on multi-line inputs.

Describe the solution you'd like

Support for automatic resizing of all text areas that are not by definition "single line":

  • Single line text fields can resize to multi-line fields
  • Text areas can resize (expand) up to a maximum size
  • Intially text area and single line fields render based on the content (up to a certain constraint).

I want these changes to be applied consistently so our users get to enjoy a uniform UX.

Describe alternatives you've considered

None.

Additional context

I believe we did have a better UX around multi-line fields in [email protected].

Related to bpmn-io/properties-panel#25


The following shows my usual flow of "editing" multi-line text:

capture WE6RXC_optimized

@nikku nikku added the enhancement New feature or request label Jul 1, 2022
@barmac barmac added the backlog Queued in backlog label Jul 6, 2022
@nikku nikku added ready Ready to be worked on and removed backlog Queued in backlog labels Jul 3, 2024
@nikku
Copy link
Member Author

nikku commented Jul 3, 2024

Moving to ready to see (review) how far we are off from consistently fixing this. We invested in the past.

@jarekdanielak
Copy link
Contributor

The problem here seems to be that the text area you are using for demonstration doesn't have autoResize property set to true.

Is this still relevant? Can you suggest which fields should have autoResize turned on?

@jarekdanielak jarekdanielak added the needs more information Requires additional information to be actionable. label Jul 17, 2024
@barmac
Copy link
Member

barmac commented Jul 17, 2024

Perhaps we want to autoresize all text areas? Make it the new default.

@nikku
Copy link
Member Author

nikku commented Jul 24, 2024

We want indeed to auto-resize all text areas (that are not by definition "single line"). This ensures a uniform UX across the whole properties panel. Cf. also camunda/camunda-modeler#4429 (comment).

@jarekdanielak
Copy link
Contributor

Fixed upstream in bpmn-io/[email protected]

@jarekdanielak jarekdanielak added fixed upstream Requires integration of upstream change and removed ready Ready to be worked on labels Jul 30, 2024
jarekdanielak added a commit that referenced this issue Jul 30, 2024
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed fixed upstream Requires integration of upstream change labels Jul 30, 2024
@barmac barmac closed this as completed in 52aa9a3 Jul 31, 2024
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs more information Requires additional information to be actionable. ux
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants