-
Notifications
You must be signed in to change notification settings - Fork 496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update dependencies and changelog #4429
Conversation
Let's follow our established practices for commits:
@jarekdanielak you can have a look into the commit log to see how this usually is done. |
e44ac74
to
5ba7a94
Compare
@jarekdanielak I wonder what our strategy was in fixing this. I still see many places in the editor where multi-line is still not supported, but should be: Missing multi-line support
Missing auto-resize:
So yea, while we partially fixed these bugs, we did not consistently addressed the user feedback. We could though 🙂. This relates to bpmn-io/bpmn-js-properties-panel#713. What I indicated there is that I think there is little value in keeping the existing "multi-line, but no auto-resize" behavior we have in some places, but instead rely on "auto-resize any multi-line field". We did not achieve that with the two incorporated fixes. I don't see the new changes break anything, hence I'm happy to merge them. In the future I'd love to see us advance/clean up things in a more holistic manner 🤩. |
Just for reference, another quirk I found in the auto-resize department: #4419 (comment). Please consider if it is worth to follow-up. |
Proposed Changes
autoResize
property (#4419)[email protected]
@bpmn-io/[email protected]
[email protected]
[email protected]
Closes #2982
Closes #4419
Checklist
To ensure you provided everything we need to look at your PR:
@bpmn-io/sr
toolCloses {LINK_TO_ISSUE}
orRelated to {LINK_TO_ISSUE}