test: fix async tests

bpmn-io · Dec 18, 2024 · f151698 · f151698
1 parent 5873297
commit f151698
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 10 deletions.
diff --git a/test/spec/DmnPropertiesPanelRenderer.spec.js b/test/spec/DmnPropertiesPanelRenderer.spec.js
@@ -421,10 +421,11 @@ describe('<DmnPropertiesPanelRenderer>', function() {
   describe('header name', function() {
 
     beforeEach(async function() {
-      await createModeler(diagramXml);
+      await act(async () => {
+        await createModeler(diagramXml);
+      });
     });
 
-
     it('should keep state during detach and attach', inject(async function(elementRegistry, selection, propertiesPanel) {
 
       // given

diff --git a/test/spec/provider/camunda/IdProps.spec.js b/test/spec/provider/camunda/IdProps.spec.js
@@ -116,10 +116,10 @@ describe('provider/dmn - IdProps', function() {
     it('should set invalid', inject(async function(elementRegistry, selection) {
 
       // given
-      const task = elementRegistry.get('Task_1');
+      const shape = elementRegistry.get('Decision_1');
 
       await act(() => {
-        selection.select(task);
+        selection.select(shape);
       });
 
       // when
@@ -129,7 +129,7 @@ describe('provider/dmn - IdProps', function() {
       });
 
       // then
-      const error = domQuery('.bio-properties-panel-input-error', container);
+      const error = domQuery('.bio-properties-panel-error', container);
       expect(error).to.exist;
     }));
 
@@ -143,8 +143,11 @@ describe('provider/dmn - IdProps', function() {
         selection.select(shape);
       });
 
-      // when
+      // expect
       const idInput = domQuery('input[name=id]', container);
+      expect(idInput.value).to.exist;
+
+      // when
       changeInput(idInput, '');
 
       // then

diff --git a/test/spec/provider/dmn/IdProps.spec.js b/test/spec/provider/dmn/IdProps.spec.js
@@ -108,20 +108,23 @@ describe('provider/dmn - IdProps', function() {
     it('should set invalid', inject(async function(elementRegistry, selection) {
 
       // given
-      const task = elementRegistry.get('Task_1');
+      const shape = elementRegistry.get('Decision_1');
 
       await act(() => {
-        selection.select(task);
+        selection.select(shape);
       });
 
-      // when
+      // expect
       const idInput = domQuery('input[name=id]', container);
+      expect(idInput.value).to.exist;
+
+      // when
       await act(() => {
         changeInput(idInput, '');
       });
 
       // then
-      const error = domQuery('.bio-properties-panel-input-error', container);
+      const error = domQuery('.bio-properties-panel-error', container);
       expect(error).to.exist;
     }));