Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display EL select only when necessary #687

Merged
merged 3 commits into from
Feb 24, 2022
Merged

Display EL select only when necessary #687

merged 3 commits into from
Feb 24, 2022

Conversation

barmac
Copy link
Member

@barmac barmac commented Feb 22, 2022 •
edited
Loading

EL select is displayed for two cases:

  • the configured EL is not the default one

  • there are multiple ELs available

  • decision table

  • literal expression

Closes #686

@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Feb 22, 2022
@barmac barmac marked this pull request as draft February 23, 2022 07:40
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed needs review Review pending labels Feb 23, 2022
@barmac barmac force-pushed the 686-do-not-display-el branch from 70669e6 to 65153b5 Compare February 23, 2022 10:18
@barmac
feat(decision-table): display EL only when necessary
be741d1 
EL entry in the context menu is displayed for two cases:
* the configured EL is not the default one
* there are multiple ELs available

Related to #686
@barmac
chore(literal-expression): extract expression language
91a18e2
@barmac
feat(literal-expression): display EL only when necessary
37012ea 
Expression language select is displayed for two cases:
* the configured EL is not the default one
* there are multiple ELs available

Closes #686
@barmac barmac force-pushed the 686-do-not-display-el branch from 65153b5 to 37012ea Compare February 23, 2022 10:18
@barmac barmac changed the title feat: display EL in context menu only when necessary Display EL select only when necessary Feb 23, 2022
@barmac barmac marked this pull request as ready for review February 23, 2022 10:19
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Feb 23, 2022
@barmac
Copy link
Member Author

barmac commented Feb 23, 2022

@MaxTru @pinussilvestrus ready for review.

MaxTru
MaxTru reviewed Feb 23, 2022
View reviewed changes
Copy link
Contributor

@MaxTru MaxTru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works and looks good!

Playing around with it, I felt that it would be great to have some more documentation around this. E.g., by including a snippet here WDYT?

@barmac
Copy link
Member Author

barmac commented Feb 23, 2022 •
edited
Loading

I think we could add some documentation for config, but as a separate issue: #688

@barmac barmac merged commit 0263e28 into develop Feb 24, 2022
@barmac barmac deleted the 686-do-not-display-el branch February 24, 2022 07:37
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxTru MaxTru MaxTru approved these changes

@pinussilvestrus pinussilvestrus Awaiting requested review from pinussilvestrus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Do not display EL dropdown when there's only one option and the set value is the default one
2 participants
@barmac @MaxTru