-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RTL direction support via properties panel (part 1) #1212
Conversation
Added StyleGroup & DirectionEntry to change the form direction globally
reformatted entries and groups
reformatted FormField and FormComponent
deleted unnecessary loggings
root seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
I made some changes before configuring my Git user; can we skip the CLA signature for |
commits' author was amended
@okaeiz We can, but major thing right now is to clean up the PR, I'll review the code afterwards. You might want to reset to bpmn-io:develop, and then cherry pick your changes into it. I see some duplicate commits, and also a tons of merge commits which we don't allow in PRs. |
If the PR isn't yet in a finished state, we usually make use of the draft functionality of github :) |
Has worked on #1205
StyleGroup
to the properties panel that is activated for the form component (default
type).DirectionEntry
to the newly-addedStyleGroup
which is a global option that sets the direction of the form components.DirectionEntry
:DirectionEntry
value)rtl
, the font is changed to Vazirmatn which has been discussed before in Camunda main repository. The font change is only applied on the so-called form components.