-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open Github issue with contents of web form #18
base: master
Are you sure you want to change the base?
Conversation
- Added a new form that connects to the Github API on submit and creates a Github issue with the contents of the form. Must add a personal token (line 295) to make it work. - Form checks for required fields and validates URL which should be an absolute URL according to these constraint: https://goo.gl/8JTigJ (AKA it must contain the protocol or it will fail)
This looks great, @gisete! We can reopen, as it is now the 1st :). Do you have a demo of this working on your work for me to try, or should I test it on my personal fork? |
Thanks @gkiar ! Yes, I created a pen on codepen for it: https://codepen.io/gk/pen/KXmJyz |
@gisete this is awesome, thanks! Let's solve setting environment variables so that we don't have the API key exposed in the javascript, and then we can merge this :) |
Great! I'll do some research and let you know what I come up with. |
Hey @gisete pinging back to see how this is going? Very excited about this :) Thanks!! |
Hi @gkiar , I did some research and asked about it to colleagues at work but couldnt find any solution for it. The only idea I've had so far is that I might have to make a different API call. Unfortunately I haven't had time to dig deeper but I'll be available to help again starting mid next week. |
Hi @gkiar, I've done some more research and here are the options I've discovered so far: |
Hi @gisete - thanks for the response, and sorry for the delay in getting back to you. |
I'd like tho say this was a good beginner friendly issue to contribute to. Thanks!
Below are some details about my code, , let me know if there is anything I'm missing.
Added a new form that connects to the Github API on submit and
creates a Github issue with the contents of the form. Must add a
personal token (line 295) to make it work. Github recommends you create an environment variable instead of showing your token in the code, https://goo.gl/89aM3u .
Form checks for required fields and validates URL which should be an
absolute URL according to these constraint: https://goo.gl/8JTigJ (AKA
it must contain the protocol or it will fail)
Fixes Open Github issue with contents of web form #13