Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

新增分页、球员位置选择、修改球员标注逻辑。 #45

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,19 @@
"react": "^16.12.0",
"react-dom": "^16.12.0",
"react-redux": "^7.2.0",
"redux": "^4.0.5"
"redux": "^4.0.5",
"save-dev": "0.0.1-security"
},
"devDependencies": {
"react-scripts": "3.4.0"
"enzyme": "^3.11.0",
"enzyme-adapter-react-16": "^1.15.2",
"react-scripts": "^3.4.0",
"react-test-renderer": "^16.13.1"
},
"browserslist": [">0.2%", "not dead", "not ie <= 11", "not op_mini all"]
"browserslist": [
">0.2%",
"not dead",
"not ie <= 11",
"not op_mini all"
]
}
11 changes: 11 additions & 0 deletions src/App.test.js
Original file line number Diff line number Diff line change
@@ -1,8 +1,19 @@
import React from 'react';
import ReactDOM from 'react-dom';
import App from './App';
import PageList from './components/PageList'
import shallow from 'enzyme'

it('renders without crashing', () => {
const div = document.createElement('div');
ReactDOM.render(<App />, div);
});

describe('PageList component',()=>{
const props = {
totalPageNumber:6,
curPageNumber:1,
}
})


10 changes: 9 additions & 1 deletion src/actions/PlayersActions.js
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
import * as types from '../constants/ActionTypes';

export function addPlayer(name) {
export function addPlayer(name,optionId) {
return {
type: types.ADD_PLAYER,
name,
optionId,
};
}

Expand All @@ -20,3 +21,10 @@ export function starPlayer(id) {
id,
};
}

export function changePage(curPageNumber) {
return {
type: types.CHANGE_PAGE,
curPageNumber,
};
}
4 changes: 4 additions & 0 deletions src/components/AddPlayerInput.css
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,7 @@
border-left: 0;
border-right: 0;
}

.inlineBlock{
display:inline-block
}
19 changes: 15 additions & 4 deletions src/components/AddPlayerInput.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,37 +2,48 @@ import React, { Component } from 'react';
import classnames from 'classnames';
import PropTypes from 'prop-types';
import styles from './AddPlayerInput.css';
import PositionSelect from './PositionSelect'

class AddPlayerInput extends Component {
render() {
const { positionList } = this.props;
return (
<input
<div>
<input
type="text"
autoFocus={true}
className={classnames('form-control', styles.addPlayerInput)}
className={classnames('form-control inlineBlock', styles.addPlayerInput)}
placeholder="Type the name of a player"
value={this.state.name}
onChange={this.handleChange.bind(this)}
onKeyDown={this.handleSubmit.bind(this)}
/>
/>
<PositionSelect positionList={positionList} onSelectChange={this.handleSelectChange.bind(this)} />
</div>

);
}

constructor(props, context) {
super(props, context);
this.state = {
name: this.props.name || '',
optionId: 0,
};
}

handleSelectChange(optionId){
this.setState({ optionId: optionId });
}

handleChange(e) {
this.setState({ name: e.target.value });
}

handleSubmit(e) {
const name = e.target.value.trim();
if (e.which === 13) {
this.props.addPlayer(name);
this.props.addPlayer(name,this.state.optionId);
this.setState({ name: '' });
}
}
Expand Down
24 changes: 24 additions & 0 deletions src/components/PageList.css
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
.pageList{
padding-left: 0;
margin-bottom: 0;
list-style: none;
}

.pageBtnAction{
width: 20px;
height: 20px;
background: white;
text-align: center;
float: left;
margin-left: 5px;
cursor: pointer;
}
.active{
color: white;
background-color: #5c75b0;
}
.pageBtnAction:focus,
.pageBtnAction:hover {
color: white;
background-color: #5c75b0;
}
23 changes: 23 additions & 0 deletions src/components/PageList.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
import React, { Component } from 'react';
import styles from './PageList.css';
import classNames from 'classnames'

class PageList extends Component {
render() {
let totalPageList = [];
for(let i = 0;i < this.props.totalPageNumber;i++){
totalPageList.push({pageId:i+1});
}
return (
<ul className="pageList">
{
totalPageList.map((v,index)=>{
return <li onClick={()=>this.props.changePage(index)} className={classNames("pageBtnAction",{"active": this.props.curPageNumber === index})} key={index}><span>{v.pageId}</span></li>
})
}
</ul>
);
}
}

export default PageList;
6 changes: 6 additions & 0 deletions src/components/PositionSelect.css
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
.positionOption{
position: absolute;
display: inline-block;
height: 34px;
border-radius: 4px;
}
23 changes: 23 additions & 0 deletions src/components/PositionSelect.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
import React, { Component } from 'react';
import {styles} from './PositionSelect.css'

class PositionSelect extends Component {
render() {
const {
positionList
} = this.props;
return (<select className="positionOption" onChange={this.onSelectChange.bind(this)}>
{
positionList.map((v,index)=>{
return <option key={index} value={index}>{v.position}</option>
})
}
</select>)
}

onSelectChange(e){
this.props.onSelectChange(e.target.value.trim());
}
}

export default PositionSelect;
2 changes: 2 additions & 0 deletions src/components/index.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
export { default as AddPlayerInput } from './AddPlayerInput';
export { default as PlayerList } from './PlayerList';
export { default as PlayerListItem } from './PlayerListItem';
export { default as PageList } from './PageList';

1 change: 1 addition & 0 deletions src/constants/ActionTypes.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
export const ADD_PLAYER = 'ADD_PLAYER';
export const STAR_PLAYER = 'STAR_PLAYER';
export const DELETE_PLAYER = 'DELETE_PLAYER';
export const CHANGE_PAGE = 'CHANGE_PAGE';
15 changes: 9 additions & 6 deletions src/containers/PlayerListApp.js
Original file line number Diff line number Diff line change
@@ -1,27 +1,29 @@
import React, { Component } from 'react';
import styles from './PlayerListApp.css';
import { connect } from 'react-redux';
import _ from 'lodash'

import { addPlayer, deletePlayer, starPlayer } from '../actions/PlayersActions';
import { PlayerList, AddPlayerInput } from '../components';
import { addPlayer, deletePlayer, starPlayer, changePage} from '../actions/PlayersActions';
import { PlayerList, AddPlayerInput, PageList } from '../components';

class PlayerListApp extends Component {
render() {
const {
playerlist: { playersById },
playerlist: { playersById, curPageNumber,pageSize,positionList}
} = this.props;

const actions = {
addPlayer: this.props.addPlayer,
deletePlayer: this.props.deletePlayer,
starPlayer: this.props.starPlayer,
changePage: this.props.changePage
};

return (
<div className={styles.playerListApp}>
<h1>NBA Players</h1>
<AddPlayerInput addPlayer={actions.addPlayer} />
<PlayerList players={playersById} actions={actions} />
<AddPlayerInput addPlayer={actions.addPlayer} positionList={positionList}/>
<PlayerList players={_.slice(playersById,curPageNumber*5,curPageNumber*5+pageSize)} actions={actions} />
<PageList totalPageNumber={(playersById.length / 5)} curPageNumber={curPageNumber} changePage={actions.changePage}/>
</div>
);
}
Expand All @@ -37,5 +39,6 @@ export default connect(
addPlayer,
deletePlayer,
starPlayer,
changePage
},
)(PlayerListApp);
12 changes: 10 additions & 2 deletions src/reducers/playerlist.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
import * as types from '../constants/ActionTypes';

const initialState = {
curPageNumber: 0,
pageSize: 5,
positionList:[{'position':'SF'},{'position':'PG'}],
playersById: [
{
name: 'LeBron James',
Expand Down Expand Up @@ -51,7 +54,7 @@ export default function players(state = initialState, action) {
{
name: action.name,
team: 'LOS ANGELES LAKERS',
position: 'SF',
position: state.positionList[action.optionId].position,
},
],
};
Expand All @@ -64,12 +67,17 @@ export default function players(state = initialState, action) {
};
case types.STAR_PLAYER:
let players = [...state.playersById];
let player = players.find((item, index) => index === action.id);
let player = players.find((item, index) => index === action.id + state.curPageNumber * state.pageSize);
player.starred = !player.starred;
return {
...state,
playersById: players,
};
case types.CHANGE_PAGE:
return {
...state,
curPageNumber: action.curPageNumber,
};

default:
return state;
Expand Down