Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement -U for Haiku. #2079

Merged
merged 6 commits into from
Nov 29, 2024
Merged

Implement -U for Haiku. #2079

merged 6 commits into from
Nov 29, 2024

Conversation

g0mb4
Copy link
Collaborator

@g0mb4 g0mb4 commented Nov 14, 2024 •
edited
Loading

Compiled with cmake -DBUILD_X11=FALSE ..

Tested on Haiku-r1beta5.
Takes part of #2072.

@github-actions github-actions bot added documentation suggests documentation changes or improvements sources PR modifies project sources labels Nov 14, 2024
@netlify Netlify
Copy link

netlify bot commented Nov 14, 2024 •
edited
Loading

✅ Deploy Preview for conkyweb canceled.

Name Link
🔨 Latest commit be9eda2
🔍 Latest deploy log https://app.netlify.com/sites/conkyweb/deploys/6745de95bea4ef000831d04c

@g0mb4
Implement -U for Haiku.
ec8fd63 
This patch also fixes a compilation error on Haiku.

Compiled with `cmake -DBUILD_X11=FALSE ..`

Tested on Haiku-r1beta5.
Takes part of brndnmtthws#2072.
@Caellian
Copy link
Collaborator

Changes to common.cc are already part of #2080. Let's get that one finished and merged first. Alternatively, given that Haiku doesn't compile at the moment (yes?), you can remove changes to common.cc to avoid difficulties with rebasing that one (given that it's larger).

@g0mb4
Copy link
Collaborator Author

g0mb4 commented Nov 16, 2024

Sure, I'll revert common.cc.

@g0mb4
Revert common.cc.
637ad69 
A cross-platform solution is already implemented in brndnmtthws#2080.
This PR will be rebased *after* the OpenBSD fix was merged.
@g0mb4 g0mb4 changed the title Implement -U for Haiku. [WIP] Implement -U for Haiku. Nov 16, 2024
@g0mb4 g0mb4 changed the title [WIP] Implement -U for Haiku. Implement -U for Haiku. Nov 26, 2024
@g0mb4
Copy link
Collaborator Author

g0mb4 commented Nov 26, 2024

Works with the latest OpenBSD and NetBSD changes.

@brndnmtthws brndnmtthws added the feature suggest addition of new functionality that isn't currently supported in any way label Nov 26, 2024
@brndnmtthws brndnmtthws merged commit 4b33da9 into brndnmtthws:main Nov 29, 2024
40 checks passed
@g0mb4 g0mb4 deleted the unique-haiku branch December 2, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brndnmtthws brndnmtthws brndnmtthws approved these changes

Assignees
No one assigned
Labels
documentation suggests documentation changes or improvements feature suggest addition of new functionality that isn't currently supported in any way sources PR modifies project sources
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@g0mb4 @Caellian @brndnmtthws