fix bug that return empty “where object” if filter contains utf8letter #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
likegun
changed the title
ricmalta
suggested changes
Jun 4, 2019
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "sequelize-querystring", | |||
| "version": "0.10.0", | |||
| "name": "sequelize-querystring-utf8", | |||
There was a problem hiding this comment.
Why do you need to change the package name?
| "name": "sequelize-querystring", | ||
| "version": "0.10.0", | ||
| "name": "sequelize-querystring-utf8", | ||
| "version": "0.10.2", |
There was a problem hiding this comment.
I would suggest to increase the version to 0.11.0
| if (expression.match(/(([\w|.]+)\s(\w+)\s([\w|\s|%|_]+),?)+/)) { | ||
| let parts = (expression).split(',') | ||
| if (expression.match(new RegExp(`(([\\w|.]+)\\s(\\w+)\\s([\\w|\\s|%|_|${utf8letters}]+),?)+`))) { | ||
| let parts = (expression).split(/,\s/) |
There was a problem hiding this comment.
Why to force a space after a condition separation?
|
@likegun Did you have any chance to have a look to my feedback? thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
findmethod,if (expression.match(/(([\w|.]+)\s(\w+)\s([\w|\s|%|_]+),?)+/)),if expression contains utf8letters the
ifcondition would be false and return empty where object.