Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some Blinds do not stop when fully opened #8

Closed
DaniEll-AT opened this issue Jan 1, 2023 · 1 comment
Closed

Some Blinds do not stop when fully opened #8

DaniEll-AT opened this issue Jan 1, 2023 · 1 comment

Comments

@DaniEll-AT
Copy link
Contributor

I am using the test-branch. There is one Venetian Blind that does not stop/turn of the relay when fully opened.

config:

cover:
  - platform: venetian_blinds
    name: "Blind-1"
    id: cover1
    open_action:
      - switch.turn_on: relay_1
    open_duration: 42900ms
    close_action:
      - switch.turn_on: relay_2
    close_duration: 43100ms
    tilt_duration: 1100ms
    stop_action:
      - switch.turn_off: relay_1
      - switch.turn_off: relay_2

log:

[10:17:22][D][cover:170]: 'Blind-1' - Publishing:
[10:17:22][D][cover:173]:   Position: 100%
[10:17:22][D][cover:184]:   Tilt: 100%
[10:17:22][D][cover:186]:   Current Operation: OPENING
[10:17:23][D][cover:170]: 'Blind-1' - Publishing:
[10:17:23][D][cover:173]:   Position: 100%
[10:17:23][D][cover:184]:   Tilt: 100%
[10:17:23][D][cover:186]:   Current Operation: OPENING
[10:17:24][D][cover:170]: 'Blind-1' - Publishing:
[10:17:24][D][cover:173]:   Position: 100%
[10:17:24][D][cover:184]:   Tilt: 100%
[10:17:24][D][cover:186]:   Current Operation: OPENING
[10:17:25][D][cover:170]: 'Blind-1' - Publishing:
[10:17:25][D][cover:173]:   Position: 100%
[10:17:25][D][cover:184]:   Tilt: 100%
[10:17:25][D][cover:186]:   Current Operation: OPENING
[10:17:26][D][cover:170]: 'Blind-1' - Publishing:
[10:17:26][D][cover:173]:   Position: 100%
[10:17:26][D][cover:184]:   Tilt: 100%
[10:17:26][D][cover:186]:   Current Operation: OPENING
[10:17:27][D][cover:170]: 'Blind-1' - Publishing:
[10:17:27][D][cover:173]:   Position: 100%
[10:17:27][D][cover:184]:   Tilt: 100%
[10:17:27][D][cover:186]:   Current Operation: OPENING
[10:17:28][D][cover:170]: 'Blind-1' - Publishing:
[10:17:28][D][cover:173]:   Position: 100%
[10:17:28][D][cover:184]:   Tilt: 100%
[10:17:28][D][cover:186]:   Current Operation: OPENING
[10:17:29][D][cover:170]: 'Blind-1' - Publishing:
[10:17:29][D][cover:173]:   Position: 100%
[10:17:29][D][cover:184]:   Tilt: 100%
[10:17:29][D][cover:186]:   Current Operation: OPENING
[10:17:30][D][cover:170]: 'Blind-1' - Publishing:
[10:17:30][D][cover:173]:   Position: 100%
[10:17:30][D][cover:184]:   Tilt: 100%
[10:17:30][D][cover:186]:   Current Operation: OPENING
[10:17:31][D][cover:170]: 'Blind-1' - Publishing:
[10:17:31][D][cover:173]:   Position: 100%
[10:17:31][D][cover:184]:   Tilt: 100%
[10:17:31][D][cover:186]:   Current Operation: OPENING

It seems is_at_target_ does not return true, but I am not experienced enough in c++ to see whats wrong there.
I will have a look again later, maybe i can come up with a fix / pull request.

@DaniEll-AT
Copy link
Contributor Author

DaniEll-AT commented Jan 1, 2023

Further research has shown: This behaviour is only visible, when close-duration is longer than open-duration.
Most of the time this is a misconfiguration (it was in my case), but it has lead me to swapped open- / close-duration assignments in VenetianBlinds::control (@pawelma FYI)

Fixed with #9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant