Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix swapped open/close duration #9

Merged
merged 1 commit into from
Jan 1, 2023
Merged

fix swapped open/close duration #9

merged 1 commit into from
Jan 1, 2023

Conversation

DaniEll-AT
Copy link
Contributor

fixes the bug described in issue #8

@DaniEll-AT DaniEll-AT mentioned this pull request Jan 1, 2023
Closed
@DaniEll-AT DaniEll-AT closed this by deleting the head repository Jan 1, 2023
pawelma
pawelma reviewed Jan 1, 2023
View reviewed changes
Copy link
Contributor

@pawelma pawelma left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, yeah that's clearly a bug :) I'm never fully opening actually as I have a high ceiling, and I'm opening only to 2.5m (~80%)

Nice catch 🍰
LGTM

@DaniEll-AT
Copy link
Contributor Author

DaniEll-AT commented Jan 1, 2023 •
edited
Loading

Thanks for the review. I'm sorry, the pull-request was closed unintentionally ;-)

@DaniEll-AT DaniEll-AT mentioned this pull request Jan 1, 2023
Closed
@DaniEll-AT DaniEll-AT reopened this Jan 1, 2023
@bruxy70 bruxy70 merged commit 4c7c5be into bruxy70:test Jan 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pawelma pawelma pawelma left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DaniEll-AT @pawelma @bruxy70