This repository has been archived by the owner on Mar 21, 2020. It is now read-only.
Removed missing parameters #15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cleaned README
brycied00d
reviewed
Jun 9, 2017
| time_format unixtime | ||
| format kvp | ||
|
|
||
| # Memory buffer with a short flush internal. |
There was a problem hiding this comment.
These parameters are actually quite valid, as this plugin is a buffered output plugin so these parameters configure the buffering.
http://docs.fluentd.org/v0.12/articles/buffer-plugin-overview
http://docs.fluentd.org/v0.12/articles/output-plugin-overview
There was a problem hiding this comment.
When I add format - in debug it says that it is never used
There was a problem hiding this comment.
I was specifically referencing the buffer parameters, that's why I placed my comment on L30
|
I'm currently extremely busy in my day-to-day life, so it'll be a little while before I can properly review this and #16 for merge. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaned README