switch to generated type declarations #2327
Conversation
| interface LoggerConfig { | ||
| debug: (msg: any) => void | ||
| info: (msg: any) => void | ||
| warn: (msg: any) => void | ||
| error: (msg: any, err?: unknown) => void | ||
| } |
There was a problem hiding this comment.
One downside to having babel transpile from TypeScript is that it's not type aware. So if you do:
export { LoggerConfig } from './common'
It fails because LoggerConfig is only a type.
Due to our requirement to support lower TS versions we couldn't do export { type LoggerConfig } from './common' which does fix the issue.
So I moved all the types to common.js which are exported like `export * from './common'`` and there are no complaints.
However, the generated types that TyeScript is now producing still do include the type modifier:
export { default } from './bugsnag';
export type { BrowserBugsnagStatic, BrowserConfig } from './bugsnag';
export * from '@bugsnag/core';
And this can't be solved by us internally not using the type modifier.
To get around this we'll have to use https://www.npmjs.com/package/downlevel-dts as a post-processing step on the types.
An added benefit of this is that internally we'll be able to use type modifier and whatever else we like that is supported by our more recent version of TypeScript
Goal
Design
Changeset
Testing