React Native CLI: reinstate notify end-to-end tests #2330
+136
−241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yousif-bugsnag
requested review from
tomlongridge,
gingerbenw and
twometresteve
yousif-bugsnag
force-pushed
the
ya/rn-cli-notify-tests
branch
from
dda75f4 to
f943fb0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Reinstates the
run-app-testsmaze runner features for the RN CLI using the dynamically generated test fixtures.These are the tests check that a built app initialized with the CLI sends sessions and events.
Design
The tests use the dynamic test fixture that is generated and built by the build + sourcemap upload tests - this has been tweaked so that the generated fixture calls
notifyon startup.I've removed the native error assertions, and the test now just verifies that a session and handled JS event are sent - there's no need to test native notify calls for the CLI, and keeping it JS only simplifies the test fixture generation.
The tests can only be run on browserstack - we can't use bitbar because endpoints are configured at build time by the CLI tool.
I've also updated the CLI test matrix to run against the latest 3 React Native versions, in line with React Native's own support policy.
Testing
Covered by a full CI run
Testing against recent RN versions has uncovered a genuine issue with the BAGP installation in 0.75+, so these are currently skipped pending a fix (BAGP installation is going to be removed altogether)