Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rust): improvements to portals commands arguments #8618

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

adrianbenavides
Copy link
Member

@adrianbenavides adrianbenavides commented Nov 11, 2024

  • Inlet create commands now have a positional argument to define the portal's name. This argument replaces the current alias or addr. Old arguments are kept as deprecated flags. To ensure backward compatibility, if a deprecated flag is used, it will take precedence over the positional argument
  • Outlet create commands also have the positional argument, as an alternative to the --from argument. In this case, we'll keep --from as a valid alternative (not deprecated).
  • InfluxDB commands now have their own args definition. This fixes the issue that was showing the TCP commands docs in the InfluxDB commands docs
  • The arguments using HostnamePort now use SchemeHostnamePort, allowing the user to optionally specify the scheme (tcp, tls or udp). The --tls and --udp flags have been deprecated (but kept), as this information can now be derived from the address arguments. To ensure backward compatibility, if a deprecated flag is used, it will take precedence over an address with an explicit scheme
  • Other args renames (with old names as valid aliases)
  • Unhide --allow flag in all the commands

@adrianbenavides adrianbenavides force-pushed the adrian/args-updates-portal-commands branch 2 times, most recently from 3b584d0 to 21a6fbe Compare November 12, 2024 08:48
@adrianbenavides adrianbenavides marked this pull request as ready for review November 12, 2024 09:08
@adrianbenavides adrianbenavides requested a review from a team as a code owner November 12, 2024 09:08
@adrianbenavides adrianbenavides marked this pull request as draft November 12, 2024 09:10
@adrianbenavides adrianbenavides force-pushed the adrian/args-updates-portal-commands branch 12 times, most recently from 14f951b to 91bb33a Compare November 13, 2024 08:45
@adrianbenavides adrianbenavides marked this pull request as ready for review November 13, 2024 08:46
@adrianbenavides adrianbenavides force-pushed the adrian/args-updates-portal-commands branch from 91bb33a to a5f0e8c Compare November 18, 2024 14:14
@adrianbenavides adrianbenavides mentioned this pull request Dec 10, 2024
etorreborre
etorreborre previously approved these changes Dec 10, 2024
Copy link
Member

@etorreborre etorreborre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry if my comments are a bit out of order. This is a good step forward but I think that could be even clearer in the naming of "addresses" so that there no ambiguity in the description on what an "address" is. Feel free to open another PR for modification.

@adrianbenavides adrianbenavides force-pushed the adrian/args-updates-portal-commands branch 2 times, most recently from 7e7aa90 to 853cc48 Compare December 18, 2024 12:32
@adrianbenavides
Copy link
Member Author

I've created issues for the open comments: #8710, #8711, #8712

etorreborre
etorreborre previously approved these changes Jan 6, 2025
@etorreborre etorreborre added this pull request to the merge queue Jan 6, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 6, 2025
@adrianbenavides adrianbenavides added this pull request to the merge queue Jan 8, 2025
Merged via the queue into develop with commit bbcd779 Jan 8, 2025
46 checks passed
@adrianbenavides adrianbenavides deleted the adrian/args-updates-portal-commands branch January 8, 2025 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants