-
-
Notifications
You must be signed in to change notification settings - Fork 559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rust): improvements to portals commands arguments #8618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3b584d0
to
21a6fbe
Compare
14f951b
to
91bb33a
Compare
91bb33a
to
a5f0e8c
Compare
Merged
etorreborre
previously approved these changes
Dec 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry if my comments are a bit out of order. This is a good step forward but I think that could be even clearer in the naming of "addresses" so that there no ambiguity in the description on what an "address" is. Feel free to open another PR for modification.
implementations/rust/ockam/ockam_command/src/influxdb/inlet/static/long_about.txt
Outdated
Show resolved
Hide resolved
implementations/rust/ockam/ockam_command/src/influxdb/outlet/create.rs
Outdated
Show resolved
Hide resolved
implementations/rust/ockam/ockam_command/src/kafka/consumer/create.rs
Outdated
Show resolved
Hide resolved
implementations/rust/ockam/ockam_command/src/kafka/inlet/create.rs
Outdated
Show resolved
Hide resolved
implementations/rust/ockam/ockam_command/src/influxdb/inlet/create.rs
Outdated
Show resolved
Hide resolved
7e7aa90
to
853cc48
Compare
etorreborre
previously approved these changes
Jan 6, 2025
853cc48
to
528e8ff
Compare
etorreborre
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
create
commands now have a positional argument to define the portal's name. This argument replaces the currentalias
oraddr
. Old arguments are kept as deprecated flags. To ensure backward compatibility, if a deprecated flag is used, it will take precedence over the positional argumentcreate
commands also have the positional argument, as an alternative to the--from
argument. In this case, we'll keep--from
as a valid alternative (not deprecated).HostnamePort
now useSchemeHostnamePort
, allowing the user to optionally specify the scheme (tcp, tls or udp). The--tls
and--udp
flags have been deprecated (but kept), as this information can now be derived from the address arguments. To ensure backward compatibility, if a deprecated flag is used, it will take precedence over an address with an explicit scheme--allow
flag in all the commands