Remove dead code #650
Merged
Remove dead code #650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zsoltk
reviewed
Jan 10, 2024
| @@ -116,6 +116,7 @@ jobs: | |||
| -Dorg.gradle.workers.max=1 | |||
| -Pandroid.testoptions.manageddevices.emulator.gpu="swiftshader_indirect" | |||
| -Pandroid.experimental.testOptions.managedDevices.emulator.showKernelLogging=true | |||
| -Dorg.gradle.jvmargs=-Xmx2048m | |||
There was a problem hiding this comment.
I don't mind, but could also be a separate PR with a reasoning in the description.
zsoltk
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes the following changes:
Removed the
:appyx-components:composablesmodule as it is neither necessary nor referenced in thesettings.gradlefile.Addressed an issue related to Instrumentation tests on CI. The recent increase in the Gradle max heap size from 2G to 4G significantly accelerated the compilation time for the
buildtask by a factor of 2x. However, this improvement had a negative impact on theInstrumentation testsdue to the increased memory footprint required for launching the emulator. To mitigate this, we have decided to revert the Gradle heap size from 4G to 2G specifically for this task.Implemented minor fixes, including the removal of unused imports, addition of missing package statements, and syntax improvements where necessary.
Check list
CHANGELOG.mdif required.