Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate typealias #651

Merged
merged 3 commits into from
Jan 11, 2024
Merged

Remove duplicate typealias #651

merged 3 commits into from
Jan 11, 2024

Conversation

manuel-martos
Copy link
Contributor

@manuel-martos manuel-martos commented Jan 11, 2024 •
edited
Loading

Description

SaveStateMap exists in two different packages:

  • com.bumble.appyx.interactions.core.state.SavedStateMap
  • com.bumble.appyx.navigation.state.SavedStateMap

The goal of this PR was just to keep only one and relocate it to utils submodule.

Check list

  • I have updated CHANGELOG.md if required.
  • I have updated documentation if required.

@manuel-martos manuel-martos linked an issue Jan 11, 2024 that may be closed by this pull request
Remove duplicate typealias #572
Closed
@manuel-martos
Copy link
Contributor Author

fix #572

@manuel-martos manuel-martos merged commit c5017b5 into bumble-tech:2.x Jan 11, 2024
7 checks passed
@manuel-martos manuel-martos deleted the remove-duplicate-typealias branch January 11, 2024 12:37
@manuel-martos manuel-martos self-assigned this Jan 23, 2024
@manuel-martos manuel-martos added cleanup Something that's no longer needed and should be removed appyx-interactions appyx-navigation labels Jan 23, 2024
@manuel-martos manuel-martos added this to the 2.0 milestone Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zsoltk zsoltk zsoltk approved these changes

Assignees

@manuel-martos manuel-martos

Labels
appyx-interactions appyx-navigation cleanup Something that's no longer needed and should be removed
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

Remove duplicate typealias
3 participants
@manuel-martos @zsoltk @mmartosdev