Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: migrate wasi-sockets tcp to worker thread #316

Closed
wants to merge 2 commits into from
Closed

chore: migrate wasi-sockets tcp to worker thread #316

wants to merge 2 commits into from

Conversation

manekinekko
Copy link
Collaborator

@manekinekko manekinekko commented Dec 15, 2023 •
edited
Loading

  • ✅preview2_tcp_bind
  • ❌ preview2_tcp_connect
  • ❌ preview2_tcp_sample_application
  • ❌ preview2_tcp_sockopts
  • ❌ preview2_tcp_states

* Failing tests are due to missing stream impl

Closes #315

guybedford
guybedford approved these changes Dec 15, 2023
View reviewed changes
Copy link
Collaborator

@guybedford guybedford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for starting on this! It would be great to land this with the unit and lint test fixes, then continue to iterate in due course.

@guybedford
Copy link
Collaborator

Landed in 823fa9b.

@guybedford guybedford closed this Dec 15, 2023
@manekinekko
Copy link
Collaborator Author

Hahaha! Just pushed a commit fixing the lint issue. Will push to another PR :)

@manekinekko
Copy link
Collaborator Author

Follow up PR #319

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guybedford guybedford guybedford approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate current wasi-sockets TCP impl to worker thread
2 participants
@manekinekko @guybedford