chore(examples): add examples #507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm going to assume that the failing test is unrelated, considering none of the actually important code changed. Possibly a problem with ubuntu latest? |
|
Yes, just a flake. |
vados-cosmonic
force-pushed
the
chore(examples)=add-examples
branch
10 times, most recently
from
96b3ca3 to
5067303
Compare
|
Hey @guybedford this is finally ready for review -- example CI is working properly [EDIT] I'm also fine not committing the per-project WASM binaries -- so I could take those out... Would lighten the repo a bit |
vados-cosmonic
force-pushed
the
chore(examples)=add-examples
branch
from
00c6834 to
46792e4
Compare
This commit adds examples to the jco, some of which are/will be referenced from the component-model book (https://component-model.bytecodealliance.org/). Signed-off-by: Victor Adossi <[email protected]>
vados-cosmonic
force-pushed
the
chore(examples)=add-examples
branch
from
46792e4 to
a54e0a8
Compare
guybedford
approved these changes
Oct 15, 2024
examples/components/string-reverse-upper/string-reverse-upper.mjs
Outdated
Show resolved
Hide resolved
Co-authored-by: Guy Bedford <[email protected]>
Signed-off-by: Victor Adossi <[email protected]>
Signed-off-by: Victor Adossi <[email protected]>
vados-cosmonic
force-pushed
the
chore(examples)=add-examples
branch
from
416f367 to
8f776c3
Compare
|
Sorry for the delay, thanks for the detailed review -- I was able to hit everything! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds examples to the jco, some of which are/will be referenced from the component-model book (https://component-model.bytecodealliance.org/).