REFACTOR: daily data tracker #1658
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c9s
reviewed
Jul 9, 2024
pkg/util/countdown.go
Outdated
| log "github.com/sirupsen/logrus" | ||
| ) | ||
|
|
||
| type Countdown struct { |
There was a problem hiding this comment.
DailyDataTracker or PeriodicDataTracker
narumiruna
force-pushed
the
narumi/countdown
branch
2 times, most recently
from
a57b663
to
8fc643e
Compare
narumiruna
force-pushed
the
narumi/countdown
branch
from
8fc643e
to
986613b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors the
FeeBudgetclass to replace theStatestructure with a newDailyDataTrackerutility class for better code organization and functionality. The changes also include updates to the corresponding test cases to align with the new structure.Refactoring
FeeBudgetclass:Statestructure with theDailyDataTrackerclass for tracking daily fee budgets and accumulated fees. (pkg/strategy/common/fee_budget.go)FeeBudgetto useDailyDataTrackerfor checking and resetting fee data. (pkg/strategy/common/fee_budget.go) [1] [2]Test updates:
DailyDataTrackerinstead ofStatefor validating fee budget logic. (pkg/strategy/common/fee_budget_test.go)New utility class:
DailyDataTrackerclass inpkg/util/daily_data_tracker.goto encapsulate the logic for tracking and resetting daily data. (pkg/util/daily_data_tracker.go)