Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: update binance api positionRisk to v3 #1783

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

anywhy
Copy link
Contributor

@anywhy anywhy commented Oct 17, 2024

No description provided.

@bbgokarma-bot
Copy link

Hi @anywhy,

This is KarmaBot, and we reward your contributions with tokens sent directly to your wallet to support development.

This pull request may get 248 BBG.

To receive BBG tokens, please provide your Polygon (can be Ethereum) address as an issue comment in this pull request, following this format:

polygon:0xAb5801a7D398351b8bE11C439e05C5B3259aeC9B

Once this pull request is merged, your BBG tokens will be transferred to your wallet.

--
If you're interested in our project, feel free to join our Telegram group https://t.me/bbgo_intl

Best,
KarmaBot

IsolatedWallet string `json:"isolatedWallet"`
InitialMargin fixedpoint.Value `json:"initialMargin"`
MaintMargin fixedpoint.Value `json:"maintMargin"`
PositionInitialMargin fixedpoint.Value `json:"positionInitialMargin"`
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you make it aligned with the original field, so the diff could be more clean

the field name matters, so please check the field name is matched with the original name

@c9s
Copy link
Owner

c9s commented Oct 17, 2024

build failed

@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 268 BBG

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.90%. Comparing base (2a767ab) to head (714be75).
Report is 132 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1783      +/-   ##
==========================================
- Coverage   24.11%   23.90%   -0.22%     
==========================================
  Files         617      623       +6     
  Lines       37569    38170     +601     
==========================================
+ Hits         9060     9123      +63     
- Misses      27711    28251     +540     
+ Partials      798      796       -2     
Files with missing lines Coverage Δ
...e/binanceapi/futures_get_position_risks_request.go 0.00% <ø> (ø)

... and 8 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9a7503...714be75. Read the comment docs.

@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 288 BBG

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants