-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kanit V2 for Google Fonts #15
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in it), "documentation" and "scripts" folders
…s not enabled for this one)
…them automatically
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello :)
Diff reports : Kanit-diff.zip
Fontbakery report
Fontbakery version: 0.7.26
[1] Family checks
🔥 FAIL: Do we have the latest version of FontBakery installed?
com.google.fonts/check/fontbakery_version
🔥 FAIL Unable to detect what's the latest version of FontBakery available. Maybe we're offline? Please check Internet access and try again.
[7] Kanit-Black.ttf
⚠ WARN: Checking OS/2 achVendID.
[code: unknown]
⚠ WARN: Stricter unitsPerEm criteria for Google Fonts.
⚠ WARN: Glyphs are similiar to Google Fonts version?
com.google.fonts/check/production_glyphs_similarity
⚠ WARN Following glyphs differ greatly from Google Fonts version: [uni0E43, uni0E44, uni0E42]
⚠ WARN: Check if each glyph has the recommended amount of contours.
The following glyphs do not have the recommended number of contours:
Glyph name: uni0E10 Contours detected: 2 Expected: 1 or 5
Glyph name: fi Contours detected: 1 Expected: 3
Glyph name: uni0E10 Contours detected: 2 Expected: 1 or 5 [code: contour-count]
⚠ WARN: Is there kerning info for non-ligated sequences?
⚠ WARN GPOS table lacks kerning info for the following non-ligated sequences:
[code: lacks-kern-info]
⚠ WARN: Check mark characters are in GDEF mark glyph class)
acutecomb, dotbelowcomb, gravecomb, hookabovecomb, nikhahit_maiChattawathai, nikhahit_maiChattawathai.narrow, nikhahit_maiEkthai, nikhahit_maiEkthai.narrow, nikhahit_maiThothai, nikhahit_maiThothai.narrow and 54 more. [code: spacing-mark-glyphs]
⚠ WARN: Check mark characters are in GDEF mark glyph class
U+0300, U+0301, U+0302, U+0303, U+0304, U+0306, U+0307, U+0308, U+0309, U+030A, U+030B, U+030C, U+031B, U+0323, U+0324, U+0326, U+0327, U+0328, U+032E, U+0331, U+0E31, U+0E34, U+0E35, U+0E36, U+0E37, U+0E38, U+0E39, U+0E3A, U+0E47, U+0E48, U+0E49, U+0E4A, U+0E4B, U+0E4C, U+0E4D and U+0E4E [code: mark-chars]
[7] Kanit-BlackItalic.ttf
⚠ WARN: Checking OS/2 achVendID.
[code: unknown]
⚠ WARN: Stricter unitsPerEm criteria for Google Fonts.
⚠ WARN: Glyphs are similiar to Google Fonts version?
com.google.fonts/check/production_glyphs_similarity
⚠ WARN Following glyphs differ greatly from Google Fonts version: [uni0E43, uni0E44, uni0E42]
⚠ WARN: Check if each glyph has the recommended amount of contours.
The following glyphs do not have the recommended number of contours:
Glyph name: uni0E10 Contours detected: 2 Expected: 1 or 5
Glyph name: fi Contours detected: 1 Expected: 3
Glyph name: uni0E10 Contours detected: 2 Expected: 1 or 5 [code: contour-count]
⚠ WARN: Is there kerning info for non-ligated sequences?
⚠ WARN GPOS table lacks kerning info for the following non-ligated sequences:
[code: lacks-kern-info]
⚠ WARN: Check mark characters are in GDEF mark glyph class)
acutecomb, dotbelowcomb, gravecomb, hookabovecomb, nikhahit_maiChattawathai, nikhahit_maiChattawathai.narrow, nikhahit_maiEkthai, nikhahit_maiEkthai.narrow, nikhahit_maiThothai, nikhahit_maiThothai.narrow and 54 more. [code: spacing-mark-glyphs]
⚠ WARN: Check mark characters are in GDEF mark glyph class
U+0300, U+0301, U+0302, U+0303, U+0304, U+0306, U+0307, U+0308, U+0309, U+030A, U+030B, U+030C, U+031B, U+0323, U+0324, U+0326, U+0327, U+0328, U+032E, U+0331, U+0E31, U+0E34, U+0E35, U+0E36, U+0E37, U+0E38, U+0E39, U+0E3A, U+0E47, U+0E48, U+0E49, U+0E4A, U+0E4B, U+0E4C, U+0E4D and U+0E4E [code: mark-chars]
[7] Kanit-Medium.ttf
⚠ WARN: Checking OS/2 achVendID.
[code: unknown]
⚠ WARN: Stricter unitsPerEm criteria for Google Fonts.
⚠ WARN: Glyphs are similiar to Google Fonts version?
com.google.fonts/check/production_glyphs_similarity
⚠ WARN Following glyphs differ greatly from Google Fonts version: [uni0E43, uni0E44, uni0E42]
⚠ WARN: Check if each glyph has the recommended amount of contours.
The following glyphs do not have the recommended number of contours:
Glyph name: uni0E10 Contours detected: 2 Expected: 1 or 5
Glyph name: uni0E3F Contours detected: 5 Expected: 3
Glyph name: fi Contours detected: 1 Expected: 3
Glyph name: uni0E10 Contours detected: 2 Expected: 1 or 5
Glyph name: uni0E3F Contours detected: 5 Expected: 3 [code: contour-count]
⚠ WARN: Is there kerning info for non-ligated sequences?
⚠ WARN GPOS table lacks kerning info for the following non-ligated sequences:
[code: lacks-kern-info]
⚠ WARN: Check mark characters are in GDEF mark glyph class)
acutecomb, dotbelowcomb, gravecomb, hookabovecomb, nikhahit_maiChattawathai, nikhahit_maiChattawathai.narrow, nikhahit_maiEkthai, nikhahit_maiEkthai.narrow, nikhahit_maiThothai, nikhahit_maiThothai.narrow and 54 more. [code: spacing-mark-glyphs]
⚠ WARN: Check mark characters are in GDEF mark glyph class
U+0300, U+0301, U+0302, U+0303, U+0304, U+0306, U+0307, U+0308, U+0309, U+030A, U+030B, U+030C, U+031B, U+0323, U+0324, U+0326, U+0327, U+0328, U+032E, U+0331, U+0E31, U+0E34, U+0E35, U+0E36, U+0E37, U+0E38, U+0E39, U+0E3A, U+0E47, U+0E48, U+0E49, U+0E4A, U+0E4B, U+0E4C, U+0E4D and U+0E4E [code: mark-chars]
[7] Kanit-MediumItalic.ttf
⚠ WARN: Checking OS/2 achVendID.
[code: unknown]
⚠ WARN: Stricter unitsPerEm criteria for Google Fonts.
⚠ WARN: Glyphs are similiar to Google Fonts version?
com.google.fonts/check/production_glyphs_similarity
⚠ WARN Following glyphs differ greatly from Google Fonts version: [uni0E43, uni0E44, uni0E42]
⚠ WARN: Check if each glyph has the recommended amount of contours.
The following glyphs do not have the recommended number of contours:
Glyph name: uni0E10 Contours detected: 2 Expected: 1 or 5
Glyph name: uni0E3F Contours detected: 5 Expected: 3
Glyph name: fi Contours detected: 1 Expected: 3
Glyph name: uni0E10 Contours detected: 2 Expected: 1 or 5
Glyph name: uni0E3F Contours detected: 5 Expected: 3 [code: contour-count]
⚠ WARN: Is there kerning info for non-ligated sequences?
⚠ WARN GPOS table lacks kerning info for the following non-ligated sequences:
[code: lacks-kern-info]
⚠ WARN: Check mark characters are in GDEF mark glyph class)
acutecomb, dotbelowcomb, gravecomb, hookabovecomb, nikhahit_maiChattawathai, nikhahit_maiChattawathai.narrow, nikhahit_maiEkthai, nikhahit_maiEkthai.narrow, nikhahit_maiThothai, nikhahit_maiThothai.narrow and 54 more. [code: spacing-mark-glyphs]
⚠ WARN: Check mark characters are in GDEF mark glyph class
U+0300, U+0301, U+0302, U+0303, U+0304, U+0306, U+0307, U+0308, U+0309, U+030A, U+030B, U+030C, U+031B, U+0323, U+0324, U+0326, U+0327, U+0328, U+032E, U+0331, U+0E31, U+0E34, U+0E35, U+0E36, U+0E37, U+0E38, U+0E39, U+0E3A, U+0E47, U+0E48, U+0E49, U+0E4A, U+0E4B, U+0E4C, U+0E4D and U+0E4E [code: mark-chars]
[6] Kanit-Thin.ttf
⚠ WARN: Checking OS/2 achVendID.
[code: unknown]
⚠ WARN: Stricter unitsPerEm criteria for Google Fonts.
⚠ WARN: Check if each glyph has the recommended amount of contours.
The following glyphs do not have the recommended number of contours:
Glyph name: uni0E10 Contours detected: 2 Expected: 1 or 5
Glyph name: uni0E3F Contours detected: 5 Expected: 3
Glyph name: fi Contours detected: 1 Expected: 3
Glyph name: uni0E10 Contours detected: 2 Expected: 1 or 5
Glyph name: uni0E3F Contours detected: 5 Expected: 3 [code: contour-count]
⚠ WARN: Is there kerning info for non-ligated sequences?
⚠ WARN GPOS table lacks kerning info for the following non-ligated sequences:
[code: lacks-kern-info]
⚠ WARN: Check mark characters are in GDEF mark glyph class)
acutecomb, dotbelowcomb, gravecomb, hookabovecomb, nikhahit_maiChattawathai, nikhahit_maiChattawathai.narrow, nikhahit_maiEkthai, nikhahit_maiEkthai.narrow, nikhahit_maiThothai, nikhahit_maiThothai.narrow and 54 more. [code: spacing-mark-glyphs]
⚠ WARN: Check mark characters are in GDEF mark glyph class
U+0300, U+0301, U+0302, U+0303, U+0304, U+0306, U+0307, U+0308, U+0309, U+030A, U+030B, U+030C, U+031B, U+0323, U+0324, U+0326, U+0327, U+0328, U+032E, U+0331, U+0E31, U+0E34, U+0E35, U+0E36, U+0E37, U+0E38, U+0E39, U+0E3A, U+0E47, U+0E48, U+0E49, U+0E4A, U+0E4B, U+0E4C, U+0E4D and U+0E4E [code: mark-chars]
[7] Kanit-ThinItalic.ttf
⚠ WARN: Checking OS/2 achVendID.
[code: unknown]
⚠ WARN: Stricter unitsPerEm criteria for Google Fonts.
⚠ WARN: Glyphs are similiar to Google Fonts version?
com.google.fonts/check/production_glyphs_similarity
⚠ WARN Following glyphs differ greatly from Google Fonts version: [Aringacute]
⚠ WARN: Check if each glyph has the recommended amount of contours.
The following glyphs do not have the recommended number of contours:
Glyph name: uni0E10 Contours detected: 2 Expected: 1 or 5
Glyph name: uni0E3F Contours detected: 5 Expected: 3
Glyph name: fi Contours detected: 1 Expected: 3
Glyph name: uni0E10 Contours detected: 2 Expected: 1 or 5
Glyph name: uni0E3F Contours detected: 5 Expected: 3 [code: contour-count]
⚠ WARN: Is there kerning info for non-ligated sequences?
⚠ WARN GPOS table lacks kerning info for the following non-ligated sequences:
[code: lacks-kern-info]
⚠ WARN: Check mark characters are in GDEF mark glyph class)
acutecomb, dotbelowcomb, gravecomb, hookabovecomb, nikhahit_maiChattawathai, nikhahit_maiChattawathai.narrow, nikhahit_maiEkthai, nikhahit_maiEkthai.narrow, nikhahit_maiThothai, nikhahit_maiThothai.narrow and 54 more. [code: spacing-mark-glyphs]
⚠ WARN: Check mark characters are in GDEF mark glyph class
U+0300, U+0301, U+0302, U+0303, U+0304, U+0306, U+0307, U+0308, U+0309, U+030A, U+030B, U+030C, U+031B, U+0323, U+0324, U+0326, U+0327, U+0328, U+032E, U+0331, U+0E31, U+0E34, U+0E35, U+0E36, U+0E37, U+0E38, U+0E39, U+0E3A, U+0E47, U+0E48, U+0E49, U+0E4A, U+0E4B, U+0E4C, U+0E4D and U+0E4E [code: mark-chars]
Summary
Note: The following loglevels were omitted in this report: