fix sending issue (#1840)

* fix sending issue * Update pr_test_build_android.yml
cake-tech · Nov 29, 2024 · bd38393 · bd38393
1 parent de970fc
commit bd38393
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 16 deletions.
diff --git a/.github/workflows/pr_test_build_android.yml b/.github/workflows/pr_test_build_android.yml
@@ -53,7 +53,7 @@ jobs:
       - name: Flutter action
         uses: subosito/flutter-action@v1
         with:
-          flutter-version: "3.24.4"
+          flutter-version: "3.24.0"
           channel: stable
 
       - name: Install package dependencies

diff --git a/android/app/src/main/AndroidManifestBase.xml b/android/app/src/main/AndroidManifestBase.xml
@@ -1,4 +1,5 @@
-<manifest xmlns:android="http://schemas.android.com/apk/res/android">
+<manifest xmlns:android="http://schemas.android.com/apk/res/android"
+    package="__APP_PACKAGE__">
 
     <uses-permission android:name="android.permission.INTERNET" />
     <uses-permission android:name="android.permission.USE_FINGERPRINT" />

diff --git a/lib/view_model/send/send_view_model.dart b/lib/view_model/send/send_view_model.dart
@@ -534,16 +534,6 @@ abstract class SendViewModelBase extends WalletChangeListenerViewModel with Stor
       throw Exception('Priority is null for wallet type: ${wallet.type}');
     }
 
-    if (hasCoinControl) {
-      bool isCoinSelected = false;
-      for (var coin in unspentCoinsListViewModel.items) {
-        isCoinSelected = isCoinSelected || (coin.isSending && !coin.isFrozen);
-      }
-      if (!isCoinSelected) {
-        throw Exception("No coin selected in coin control, you need to select a coin in order to spend");
-      }
-    }
-
     switch (wallet.type) {
       case WalletType.bitcoin:
       case WalletType.litecoin:

diff --git a/scripts/android/app_env.sh b/scripts/android/app_env.sh
@@ -15,15 +15,15 @@ TYPES=($MONERO_COM $CAKEWALLET $HAVEN)
 APP_ANDROID_TYPE=$1
 
 MONERO_COM_NAME="Monero.com"
-MONERO_COM_VERSION="1.18.1"
-MONERO_COM_BUILD_NUMBER=106
+MONERO_COM_VERSION="1.18.2"
+MONERO_COM_BUILD_NUMBER=107
 MONERO_COM_BUNDLE_ID="com.monero.app"
 MONERO_COM_PACKAGE="com.monero.app"
 MONERO_COM_SCHEME="monero.com"
 
 CAKEWALLET_NAME="Cake Wallet"
-CAKEWALLET_VERSION="4.21.1"
-CAKEWALLET_BUILD_NUMBER=237
+CAKEWALLET_VERSION="4.21.2"
+CAKEWALLET_BUILD_NUMBER=238
 CAKEWALLET_BUNDLE_ID="com.cakewallet.cake_wallet"
 CAKEWALLET_PACKAGE="com.cakewallet.cake_wallet"
 CAKEWALLET_SCHEME="cakewallet"