Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix data type errors creating nonmajor_safety_and_security_events tables #3756

Merged

Conversation

erikamov
Copy link
Contributor

@erikamov erikamov commented Mar 8, 2025

Description

This PR fixes data type errors and adds new columns from the Non Major Safety and Security Events.
Also removes extra CTEs to reduce costs on processing the query.

Resolves [#3745]

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

How has this been tested?

Tested locally and models created on staging.
Screenshot 2025-03-07 at 4 07 01 PM

Post-merge follow-ups

  • No action required
  • Actions required (specified below)

Check transform_warehouse logs to confirm no more errors from this table.

@erikamov erikamov requested a review from ohrite March 8, 2025 00:14
@erikamov erikamov self-assigned this Mar 8, 2025
Copy link
Contributor

@ohrite ohrite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍐 Paired w/ @erikamov

@erikamov erikamov assigned ohrite and erikamov and unassigned erikamov Mar 8, 2025
Copy link

github-actions bot commented Mar 8, 2025

Warehouse report 📦

DAG

Legend (in order of precedence)

Resource type Indicator Resolution
Large table-materialized model Orange Make the model incremental
Large model without partitioning or clustering Orange Add partitioning and/or clustering
View with more than one child Yellow Materialize as a table or incremental
Incremental Light green
Table Green
View White

@erikamov erikamov force-pushed the mov/3745-error-fct_fra_regulated_mode_major_security_events branch 3 times, most recently from eba634a to e0517d3 Compare March 8, 2025 00:25
@erikamov erikamov force-pushed the mov/3745-error-fct_fra_regulated_mode_major_security_events branch from e0517d3 to c9d6af2 Compare March 8, 2025 00:25
@erikamov erikamov merged commit abb5d38 into main Mar 8, 2025
4 checks passed
@erikamov erikamov deleted the mov/3745-error-fct_fra_regulated_mode_major_security_events branch March 8, 2025 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants