Should allow github action to find netlify #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview url: https://PR-329--cal-itp-reports.netlify.app |
|
This worked! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The error message was "netlify: command not found". This should install it globally so if it installed correctly, it can be found*!
*Though the recommend way to use netlify in this situation is --save-dev but we are moving on from netlify soon anyways.
Possibly Resolves #327
Type of change
How has this been tested?
Not tested properly yet!
Did a little testing locally. I might be able to add
... npx netlifyto the beginning and that might work as well. Or possiblynpm install netlify-cli --save-devI don't know why this stopped working! But to be fair we haven't locked down many of the package versions.
Screenshots (optional)