Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweeked email template #330

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Tweeked email template #330

merged 1 commit into from
Jan 9, 2025

Conversation

vevetron
Copy link
Contributor

@vevetron vevetron commented Jan 9, 2025

Description

Tweeked email template a little bit so signature doesn't get covered up.

Resolves #319

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

How has this been tested?

Sent a test email to myself and Christian with
poetry run python generate_report_emails.py production

Screenshots (optional)

image

@vevetron vevetron removed the request for review from csuyat-dot January 9, 2025 20:22
Copy link

github-actions bot commented Jan 9, 2025

Preview url: https://PR-330--cal-itp-reports.netlify.app

Copy link
Contributor

@csuyat-dot csuyat-dot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. signature block appears when viewed in outlook desktop and browser version.

@vevetron vevetron merged commit 2822013 into main Jan 9, 2025
2 checks passed
@vevetron vevetron deleted the fix_email_sig_bug branch January 9, 2025 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Reports Email is cutting off signature line
2 participants