Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WD-18634] Ref: use form generator on landscape bubble #14685

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

muhammad-ali-pk
Copy link
Contributor

@muhammad-ali-pk muhammad-ali-pk commented Jan 28, 2025

Done

  • Added two forms, one for "managed" and one for "landing, features, compare"
  • Moved "templates/landscape/managed.html" to "templates/landscape/managed/index.html"

QA

  • Open the demo in your browser
  • Navigate to the following pages
    • Landing
    • Features
    • Managed
    • Compare
  • Click on "Contact us" buttons
  • Make sure the form is visible
  • Submit the forms and make sure they work.

Issue / Card

Fixes #WD-18634

@webteam-app
Copy link

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.32%. Comparing base (c4540a6) to head (fff79a2).
Report is 19 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14685   +/-   ##
=======================================
  Coverage   72.32%   72.32%           
=======================================
  Files         120      120           
  Lines        3404     3404           
  Branches     1172     1177    +5     
=======================================
  Hits         2462     2462           
  Misses        917      917           
  Partials       25       25           

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants