Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Do not use xsenv please! #119

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: Do not use xsenv please! #119

wants to merge 3 commits into from

Conversation

danjoa
Copy link
Contributor

@danjoa danjoa commented Jan 17, 2025

CAP and @cap-js should never use xsenv please but always cds.env instead

SoujitD-SAP
SoujitD-SAP previously approved these changes Jan 27, 2025
Copy link
Contributor

@SoujitD-SAP SoujitD-SAP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implemented and tested the required changes.

@SoujitD-SAP SoujitD-SAP self-requested a review February 7, 2025 20:13
@SoujitD-SAP SoujitD-SAP dismissed their stale review February 7, 2025 20:24

found some minor bug in implementation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants