Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify readme for case where other gems are overriding #76

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

will-in-wi
Copy link
Contributor

Another shot at a solution for #58

Thoughts?

@will-in-wi will-in-wi mentioned this pull request Oct 13, 2017
set :rbenv_roles, :all # default value
# The following are defaults. You should #append to them in case other gems
# have also overriden them.
#set :rbenv_prefix, "RBENV_ROOT=#{fetch(:rbenv_path)} RBENV_VERSION=#{fetch(:rbenv_ruby)} #{fetch(:rbenv_path)}/bin/rbenv exec"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

append doesn't make sense to apply to :rbenv_prefix, right? Maybe it should be moved to a different section?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants