Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readd the missing class !members list. #4828

Merged

Conversation

dwblaikie
Copy link
Contributor

@dwblaikie dwblaikie commented Jan 21, 2025

Thanks to danakj for spotting this was removed accidentally in #4732

Thanks to @danakj for spotting this.
Copy link
Contributor

@jonmeow jonmeow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NB, removed in #4732 (maybe worth noting in the PR description?)

Also, to be sure you're aware, when you @ someone in the PR description, it also notifies them from the actual commit (i.e., merge to trunk) because the @ is mirrored over. I tend to avoid doing @ in PR descriptions as a consequence.

@dwblaikie dwblaikie added this pull request to the merge queue Jan 21, 2025
@dwblaikie
Copy link
Contributor Author

NB, removed in #4732 (maybe worth noting in the PR description?)

Ah, yep - added.

Also, to be sure you're aware, when you @ someone in the PR description, it also notifies them from the actual commit (i.e., merge to trunk) because the @ is mirrored over. I tend to avoid doing @ in PR descriptions as a consequence.

Ah, right (you might've mentioned that to me/near me before, sorry I forgot) - good to know/keep in mind. Will try to remember to do that in a follow-up comment or the like in the future.

Copy link
Contributor

@danakj danakj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

Merged via the queue into carbon-language:trunk with commit 667a010 Jan 21, 2025
10 checks passed
@dwblaikie dwblaikie deleted the readd_semir_class_members branch January 21, 2025 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants